[DPE-4669] Test: Scale to zero units #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalabaDmitri
force-pushed
the
scaling_to_zero
branch
2 times, most recently
from
cb77a05
to
95ed5b5
Compare
dragomirp
requested review from
marceloneppel,
dragomirp,
lucasgameiroborges and
taurus-forever
BalabaDmitri
force-pushed
the
scaling_to_zero
branch
from
95ed5b5
to
1681d0f
Compare
|
Hi @BalabaDmitri ! |
BalabaDmitri
force-pushed
the
scaling_to_zero
branch
from
86c8c58
to
a195d6a
Compare
marceloneppel
requested changes
Jun 14, 2024
| connection_string: Database connection string | ||
| """ | ||
| with psycopg2.connect(connection_string) as connection: | ||
| connection.autocommit = True |
There was a problem hiding this comment.
I believe this is not needed when you have a read-only statement only.
Comment on lines
+493
to
+494
| logger.info("scaling to one unit") | ||
| await scale_application(ops_test, app, 1) |
There was a problem hiding this comment.
This is a great addition to the tests (I mean scaling from 0 to 1 unit and later from 1 to 3 units to ensure it works after this sequence of operations).
What I see missing is the previously checked situation, which scales from 0 to 3 units.
Comment on lines
+829
to
+830
| if self._patroni.cluster_system_id_mismatch(unit_name=self.unit.name): | ||
| self.unit.status = BlockedStatus(THIRD_PARTY_STORAGE_MESSAGE) |
There was a problem hiding this comment.
Question: this blocked status can only be resolved by removing the unit and fixing the storage.
If so, I think we can return directly without calling event.defer().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #508
Solution
Test coverage of the following cases:
Implementation