{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":614611795,"defaultBranch":"main","name":"adhd","ownerLogin":"chromeos","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-03-16T00:20:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/55198424?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1721671918.0","currentOid":""},"activityList":{"items":[{"before":"4e0788a4c28e2125ed8866595658938b2647247f","after":"f7db9bd0578f04f947e426946b6a4b8b818c0502","ref":"refs/heads/main","pushedAt":"2024-09-13T16:09:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Add system_valid_nc_providers in S2 Output\n\nsystem_valid_nc_providers represents the NC providers that can be\nused if the node is compatible and the effect should be enabled.\nIt will be used to decide the stream effect and the effect restart\ntag of cras_iodev from S2.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I618e84fed4d70293f296052e77de30f9c61de779\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5856749\nCommit-Queue: ChromeOS Auto Retry \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: Add system_valid_nc_providers in S2 Output"}},{"before":"0e191df19591793c0073ce69d19ad6f75c5abab2","after":"4e0788a4c28e2125ed8866595658938b2647247f","ref":"refs/heads/main","pushedAt":"2024-09-13T11:32:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Fix unused import\n\n> warning: unused import: `crate::drc::DRC`\n> --> cras/src/dsp/rust/src/drc_bindings.rs:103:9\n> |\n> 103 | use crate::drc::DRC;\n> | ^^^^^^^^^^^^^^^\n> |\n> = note: `#[warn(unused_imports)]` on by default\n>\n> warning: 1 warning emitted\n\nBUG=None\nTEST=bazel test //...\n\nChange-Id: Iefe70cdda302f99ca4f33d4ad60201054b28b69a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5859715\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Norman Bintang \nCommit-Queue: Li-Yu Yu ","shortMessageHtmlLink":"Fix unused import"}},{"before":"e46cb1993291c6cab78cd98254414437fb906e91","after":"0e191df19591793c0073ce69d19ad6f75c5abab2","ref":"refs/heads/main","pushedAt":"2024-09-13T07:51:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Add nc_effect_for_ui_toggle in S2\n\nnc_effect_for_ui_toggle defines the NC effect type of the UI toggle.\nThe design is at go/cras-audio-effects-control .\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nCq-Depend: chromium:5850891\nChange-Id: I960b085db0feb3c277e73127c4958715ce230244\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5853332\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Hung-Hsien Chen \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: Add nc_effect_for_ui_toggle in S2"}},{"before":"9ffd11d436409df485e4aabdad3209a82ebfcbe3","after":"e46cb1993291c6cab78cd98254414437fb906e91","ref":"refs/heads/main","pushedAt":"2024-09-13T06:59:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: fix effect selection bug of Style Transfer and AP NC\n\nOn devices with Style Transfer, when internal mic is active,\nthe UI is a toggle for Style Transfer;\nwhen external mic is active, the UI is a toggle for NC.\n\nIf\n1. Select external mic.\n2. Turn on the NC toggle.\n3. Select internal mic.\n4. Turn off the Style Transfer toggle.\n\nThe expected effect is NoEffects, but currently it will get NoiseCancellation.\n\nThis CL fixes the issue.\n\nBUG=b:364812248\nFIXED=b:364812248\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I7eaa07edb054e8965b4273f7fd138ce115eab657\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5839085\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Cranel W \nCommit-Queue: Hung-Hsien Chen ","shortMessageHtmlLink":"CRAS: fix effect selection bug of Style Transfer and AP NC"}},{"before":"92b202887f859d6d5f78843e73fa3113877fd751","after":"9ffd11d436409df485e4aabdad3209a82ebfcbe3","ref":"refs/heads/main","pushedAt":"2024-09-13T05:08:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Add default volume curve setting for usb device in board.ini\n\nSome USB audio devices, particularly CFM devices, experienced volume control issues after a recent change to Chromium (crrev/c/3398101).\n\ncrrev/c/3398101 introduced device-specific volume curves, which caused compatibility problems with certain peripherals.\n\nTo address this, a flag is being added to board.ini to allow restoring the previous universal volume curve behavior.\n\nBUG=b:278266194\nBUG=b:359577344\nTEST=test affected audio device and make sure volume can adjust smoothly .\n\nChange-Id: Ib71da9de2264b1e0fa825fe871ff0ec7273e4f5e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/4573010\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Kyle Williams \nCommit-Queue: Ching Yun Chang ","shortMessageHtmlLink":"Add default volume curve setting for usb device in board.ini"}},{"before":"f218b7e7a3f55ad6a24dd3c5ff9e02670c798030","after":"92b202887f859d6d5f78843e73fa3113877fd751","ref":"refs/heads/main","pushedAt":"2024-09-12T12:57:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Specify 1-to-5 and 2-to-5 conversion\n\nSome special devices expose 5 channels and they want to convert samples\nto the first 2 channels instead of using all-to-all conversion.\n\nBUG=b:364795766\nTEST=Not fallback to all-to-all conversion when using 5 channels device\n\nChange-Id: I6bf689add1d2826e62c954960b9361b3f7e86620\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5851154\nCommit-Queue: Yu-Hsuan Hsu \nReviewed-by: Li-Yu Yu \nTested-by: Yu-Hsuan Hsu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"CRAS: Specify 1-to-5 and 2-to-5 conversion"}},{"before":"fd4a43aef2162608557bd80f1efb861f0ea9c43a","after":"f218b7e7a3f55ad6a24dd3c5ff9e02670c798030","ref":"refs/heads/main","pushedAt":"2024-09-12T10:52:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sidetone: Allow sidetone for all audio devices\n\nAllow sidetone for all audio devices so it has higher usage.\nKeep the is_sidetone_available function to minimize the change and also\nbecause chrome still calls the related D-Bus function.\n\nBUG=b:366107569\nTEST=open google meet\nTEST=enable sidetone\n\nChange-Id: I1258c279a9314f00b7686258385daf36f4adb226\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5856520\nCommit-Queue: Norman Bintang \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"sidetone: Allow sidetone for all audio devices"}},{"before":"eb9459e3c8a399863effeea6c2c210b2b1a7aaa3","after":"fd4a43aef2162608557bd80f1efb861f0ea9c43a","ref":"refs/heads/main","pushedAt":"2024-09-12T09:40:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: Add missing Datastore::UseVPD.save for invalid rdc case\n\nThe datastore update was missing when handling an invalid rdc.\nThis change adds the necessary logic to ensure the datastore is updated\ncorrectly.\n\nBUG=b:365126547\nTEST=`tast run ${DUT} audio.SoundCardInit.*`\n\nChange-Id: Ibf2f6a2e330fec14e178690eaf75d3b6d720cc9f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5856641\nReviewed-by: Baili Deng \nCommit-Queue: Baili Deng \nCommit-Queue: ChromeOS Auto Runner \nAuto-Submit: Judy Hsiao \nTested-by: Judy Hsiao \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"sound_card_init: Add missing Datastore::UseVPD.save for invalid rdc case"}},{"before":"fc0b7f3098f2d09f3e6272377bcbf514fb722829","after":"eb9459e3c8a399863effeea6c2c210b2b1a7aaa3","ref":"refs/heads/main","pushedAt":"2024-09-12T06:29:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Update active input node compatible NC providers in S2\n\nRegister active_node_changed observer at cras_iodev_list.\nWhen active_node_changed is notified, update the active input node\ncompatible NC providers in S2.\nThis will affect the effect UI.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: Ia21f2adbdb7e426e247e3168667f0102d6e50c8c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5850065\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Hung-Hsien Chen \nReviewed-by: Pin-chih Lin \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: Update active input node compatible NC providers in S2"}},{"before":"ea575194562f4859ceeeffc4cce922ba0e20876a","after":"fc0b7f3098f2d09f3e6272377bcbf514fb722829","ref":"refs/heads/main","pushedAt":"2024-09-11T18:19:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Enable CrOSLateBootAudioStyleTransfer by default\n\nBUG=b:365040119\nTEST=CQ\n\nCq-Depend: chromium:5842006\nDisallow-Recycled-Builds: tast-failures\nChange-Id: I008782fbb5b5c08ff061325620b79bb120a561e6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5841657\nTested-by: Cranel W \nReviewed-by: Li-Yu Yu \nAuto-Submit: Cranel W \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Cranel W ","shortMessageHtmlLink":"Enable CrOSLateBootAudioStyleTransfer by default"}},{"before":"f37ca48ea5e536775eacf3cc092c02b4aed8a353","after":"ea575194562f4859ceeeffc4cce922ba0e20876a","ref":"refs/heads/main","pushedAt":"2024-09-11T15:43:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: move enum audio_effect_type to Rust as EFFECT_TYPE\n\nMoving from cras_iodev_info.h to types_internal.rs.\nEFFECT_TYPE will be used in S2.\nC files can access EFFECT_TYPE from rust_common.h.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: Ifaacaddafe7456f8f0e8509e3e4cdaa1a22cfed6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5853331\nReviewed-by: Li-Yu Yu \nReviewed-by: Cranel W \nCommit-Queue: Hung-Hsien Chen \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nTested-by: Hung-Hsien Chen ","shortMessageHtmlLink":"CRAS: move enum audio_effect_type to Rust as EFFECT_TYPE"}},{"before":"cdd08ff186a68faf00eda921421bb81ac0bcc43b","after":"f37ca48ea5e536775eacf3cc092c02b4aed8a353","ref":"refs/heads/main","pushedAt":"2024-09-11T11:23:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Add struct AudioEffectStatus in S2\n\nStore audio effect status in a HashMap in S2 Output.\nRefactored the existed audio effect status in S2 Output to the HashMap.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I8e12e63d29bf13cf6cdebe49c5578e598f74e1ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5849749\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: Hung-Hsien Chen ","shortMessageHtmlLink":"CRAS: Add struct AudioEffectStatus in S2"}},{"before":"08f1c34be3025fb700f9f993eb961c7a7c9178c1","after":"cdd08ff186a68faf00eda921421bb81ac0bcc43b","ref":"refs/heads/main","pushedAt":"2024-09-11T09:53:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"cras: Modify put_buffer to use byte-by-byte copy for debugging\n\nSubstitute memcpy with a byte-by-byte copy loop.\nThis change is intended to help isolate potential memory alignment\nproblems causing crashes, as indicated by the presence of\n__memcpy_avx_unaligned_erms in the stack trace.\n\nBUG=b:332638238\nTEST=tast run ${DUT} audio.CrasStreamMix\n\nChange-Id: Ibe9b5734c1cf6b0d385242d1a3c63da05201fd6b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5848772\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nTested-by: Judy Hsiao \nReviewed-by: Yu-Hsuan Hsu \nReviewed-by: Baili Deng \nCommit-Queue: Judy Hsiao ","shortMessageHtmlLink":"cras: Modify put_buffer to use byte-by-byte copy for debugging"}},{"before":"91dc40c7432bc12c9e1cad223ab8f83b9c2c072b","after":"08f1c34be3025fb700f9f993eb961c7a7c9178c1","ref":"refs/heads/main","pushedAt":"2024-09-11T08:26:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Do not reset next_cb_ts on running streams\n\nReset next_cb_ts may break the schedule if a stream is already attached\nto another device.\n\nBUG=b:364514332\nTEST=Run audio.FloopDeviceSwitch and check number of underruns.\n\nChange-Id: Ib542459a055c96cf467cbe7c6c9c004640dd8e7e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5851153\nReviewed-by: Li-Yu Yu \nTested-by: Yu-Hsuan Hsu \nReviewed-by: Terry Cheong \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Yu-Hsuan Hsu \nCommit-Queue: ChromeOS Auto Runner ","shortMessageHtmlLink":"CRAS: Do not reset next_cb_ts on running streams"}},{"before":"0c3b002e6785bfa68c0468ce06aaaded8df87985","after":"91dc40c7432bc12c9e1cad223ab8f83b9c2c072b","ref":"refs/heads/main","pushedAt":"2024-09-10T04:15:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"UCM: Add Lenovo docks:\n\n1.ThinkPad Hybrid USB-C with USB-A Dock\n2.ThinkPad USB-C Dock Audio\n\nDisabling hardware volumn as default and enabling software volumn to fix the small playback sound.\nThis fix ensures that the mixer control is set to the maximum volume and flags the use of software volume.\nAlso specify the input & output audio node when connecting the dock.\n\nBUG=b:357472584\nTEST=Run commands\n (outside)$ cros workon --board nissa start adhd\n (outside)$ cros_sdk emerge-nissa media-sound/adhd\n (outside)$ cros deploy $IP media-sound/adhd\n (chromebook)$ restart cras\n\nChange-Id: I6e0ec0dd4eb562359a87351dbe2efc561481f302\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5828311\nCommit-Queue: Terry Cheong \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Terry Cheong \nTested-by: Sarah Wang ","shortMessageHtmlLink":"UCM: Add Lenovo docks:"}},{"before":"debe6835a54b16b6b3aa587ad9c1cda94d993e2e","after":"0c3b002e6785bfa68c0468ce06aaaded8df87985","ref":"refs/heads/main","pushedAt":"2024-09-09T19:58:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: move CRAS_NC_PROVIDER into types_internal.rs\n\nMoving so that CRAS_NC_PROVIDER can be accessed from S2.\ncras_nc.h is removed.\nTemporarily handle resolving nc provider in cras_iodev_list,\nwhich will be replaced by S2 later.\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I92e3c7436ab03fecb33b564cab7cd29cbb0919d3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836313\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Cranel W \nCommit-Queue: Hung-Hsien Chen \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: move CRAS_NC_PROVIDER into types_internal.rs"}},{"before":"683d150582387ef363d653432b4d2f432cf02e47","after":"debe6835a54b16b6b3aa587ad9c1cda94d993e2e","ref":"refs/heads/main","pushedAt":"2024-09-09T15:39:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Not enable stream apms on floop streams\n\nFloop streams don't need any audio effect. Remove it to avoid\nresetting dsp when output devices change, which lead to reconnect\nstreams and cause underruns.\n\nBUG=b:364514332\nTEST=Run audio.FloopDeviceSwitch and check number of underruns.\n\nChange-Id: I55d284ced16d4ec02830e6a73e7d92cb96f1140c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836550\nReviewed-by: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: ChromeOS Auto Retry \nAuto-Submit: Yu-Hsuan Hsu \nTested-by: Yu-Hsuan Hsu ","shortMessageHtmlLink":"CRAS: Not enable stream apms on floop streams"}},{"before":"33118ef743a6ac0e40fa319d05de544278976a7c","after":"683d150582387ef363d653432b4d2f432cf02e47","ref":"refs/heads/main","pushedAt":"2024-09-05T22:12:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"owners: remove Paul\n\nyou will be missed\n\nBUG=None\nTEST=None\n\nChange-Id: Ib0a03534499c13f65a764eec9cb8ee41c038163e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5840487\nAuto-Submit: Curtis Malainey \nReviewed-by: Li-Yu Yu \nTested-by: Curtis Malainey \nCommit-Queue: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"owners: remove Paul"}},{"before":"551f056147e78ee02661eb95f5ac512a7cdda73d","after":"33118ef743a6ac0e40fa319d05de544278976a7c","ref":"refs/heads/main","pushedAt":"2024-09-05T13:54:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: clean up for moving nc_standalone_mode to S2\n\nRemove cras_system_get_noise_cancellation_standalone_mode().\nAll usage of this function is removed in https://crrev.com/c/5823496 .\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: I5b92db1eb6670e10ca4a2499368a578b6016c620\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836312\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Hung-Hsien Chen \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"CRAS: clean up for moving nc_standalone_mode to S2"}},{"before":"b96e1235b76b737efb33276baefb5ee71929e94d","after":"551f056147e78ee02661eb95f5ac512a7cdda73d","ref":"refs/heads/main","pushedAt":"2024-09-05T11:03:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"Use cros format for Rust code\n\nBUG=None\nTEST=cros format `git ls-files '*.rs'`\n\nChange-Id: I2fc919fe377859096274ca4a7611d398d2fe343c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5839086\nCommit-Queue: Hung-Hsien Chen \nCommit-Queue: Li-Yu Yu \nTested-by: Li-Yu Yu \nReviewed-by: Hung-Hsien Chen \nAuto-Submit: Li-Yu Yu ","shortMessageHtmlLink":"Use cros format for Rust code"}},{"before":"925eaf211cf54d77c82b27b51a662b64f5d67af8","after":"b96e1235b76b737efb33276baefb5ee71929e94d","ref":"refs/heads/main","pushedAt":"2024-09-05T08:18:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"sound_card_init: update VPD for rma_calibration\n\nPreviously it stored new calibration result in\n/var/lib/sound_card_init/. However, according to go/cros-fs-layout,\n/var/lib/ will be cleared after powerwash.\n\nShimless RMA process will disable write protection, so it would be\nmore robust to store calibration to VPD as well.\n\nThe result will be both stored in VPD and /var/lib/sound_card_init/\nas the boot time calibration saves to /var/lib/sound_card_init/ and\n/var/lib/sound_card_init/ has high priorty than VPD results.\n\nBUG=b:359708232\nTEST=`sound_card_init rma_calibration --id sofnau8825 --conf \\\n volmar.MAX98373.yaml --amp MAX98373`\n\n TEST=`/usr/bin/sound_card_init rma_calibration --id sofrt5682\n --amp\\\n MAX98390 --conf redrix.MAX98390.yaml`\n\nChange-Id: Ib74ec753e932470ae9d5ffdf53ef21cc59216789\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5833425\nReviewed-by: Baili Deng \nCommit-Queue: Judy Hsiao \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"sound_card_init: update VPD for rma_calibration"}},{"before":"09573910b688fa7be92c563533adbc69d5fc7abf","after":"925eaf211cf54d77c82b27b51a662b64f5d67af8","ref":"refs/heads/main","pushedAt":"2024-09-05T07:28:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"cras_tests: Print underrun duration\n\nBUG=b:364474071\nTEST=cras_tests control dump_audio_debug_info\n\nChange-Id: Ifc49705886d8df554539e97b0c5c0a85f8b521f5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5829327\nAuto-Submit: Yu-Hsuan Hsu \nReviewed-by: Li-Yu Yu \nReviewed-by: Yu-Hsuan Hsu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nTested-by: Yu-Hsuan Hsu \nCommit-Queue: Yu-Hsuan Hsu ","shortMessageHtmlLink":"cras_tests: Print underrun duration"}},{"before":"6e15583898db2c43ed40efd3863cb5feda663680","after":"09573910b688fa7be92c563533adbc69d5fc7abf","ref":"refs/heads/main","pushedAt":"2024-09-05T05:49:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"ucm_converter: update config path and add enum_mixer_numeric_fallback attr\n\nBUG=b:348124498\nTEST=`python3 convert_all_ucm.py \\\n ${SRC}/overlays/overlay-brya/chromeos-base/chromeos-bsp-brya/files \\\n ../configs/ mixer`\n\nTEST=`python3 convert_all_ucm.py \\\n ${SRC}/overlays/overlay-brya/chromeos-base/chromeos-bsp-brya/files \\\n ../configs/ xml`\n\nChange-Id: I314c2b3b52c855819c9025f06f1793d62ddb71f9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5836311\nTested-by: Judy Hsiao \nCommit-Queue: Judy Hsiao \nCommit-Queue: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: ChromeOS Auto Runner \nAuto-Submit: Judy Hsiao ","shortMessageHtmlLink":"ucm_converter: update config path and add enum_mixer_numeric_fallback…"}},{"before":"ca16bc2a61ed0a751f334dcde54f861e259ab202","after":"6e15583898db2c43ed40efd3863cb5feda663680","ref":"refs/heads/main","pushedAt":"2024-09-03T13:49:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"floop: make no stream playback no-op\n\nWhen playback is not active, flexible loopback should return frames\nfilled with zeros. But this is handled in input side since there would\nbe cases that the playback side didn't started at all.\n\nSetting it to limit the source of filling zeros and avoid overfilling\nthe buffer.\n\nBUG=b:362679648\nTEST=tast run audio.FloopLifecycle.*\n\nChange-Id: Ib8a0e158d994064de8a91f14c8c3149f3bc0e632\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5828312\nTested-by: Terry Cheong \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Yu-Hsuan Hsu \nCommit-Queue: Terry Cheong ","shortMessageHtmlLink":"floop: make no stream playback no-op"}},{"before":"a28560d18a5854b4666aa0cc8606f5feea63c5b4","after":"ca16bc2a61ed0a751f334dcde54f861e259ab202","ref":"refs/heads/main","pushedAt":"2024-09-02T16:39:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"floop: avoid overfilling the buffer\n\nAccount for the frames queued in buffer when filling zeros.\n\nBUG=None\nTEST=tast run audio.FloopLifecycle.*\n\nChange-Id: If069f64a1af5c2dc7f20d6d0b70981444fcdaf32\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/4721135\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Terry Cheong \nReviewed-by: Li-Yu Yu ","shortMessageHtmlLink":"floop: avoid overfilling the buffer"}},{"before":"0fe3ecc133a7694cf3527737921b985152adde6e","after":"a28560d18a5854b4666aa0cc8606f5feea63c5b4","ref":"refs/heads/main","pushedAt":"2024-09-02T03:35:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Attach streams at the same time\n\nAttach streams at the same time instead of adding them seperately. It\ncan avoid the first stream from committing data to a device before the\nsecond stream is added.\n\nBUG=b:361243861\nTEST=Switch devices when using Recorder App and Youtube at the same\ntime.\n\nChange-Id: I8e25045768e853680998efd0e92c1836a87316c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5828304\nReviewed-by: Li-Yu Yu \nReviewed-by: Terry Cheong \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Yu-Hsuan Hsu \nTested-by: Yu-Hsuan Hsu ","shortMessageHtmlLink":"CRAS: Attach streams at the same time"}},{"before":"90235d26e603d428dcaeee3d60ad0656bed4406c","after":"0fe3ecc133a7694cf3527737921b985152adde6e","ref":"refs/heads/main","pushedAt":"2024-08-30T10:09:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: move DSP input effect blocking into S2.\n\nThe DSP input effect blocking flags were implemented in cras_iodev_list.\nMoving them into S2.\n\nThe audio effect decision process will need DSP blocking information in\nS2. It affects what to show in UI setting and which effect to apply on\nthe stream.\n\nDetailed design: go/cras-audio-effects-control .\n\nBUG=b:353627012\nTEST=bazel test //... --config=local-clang --//:apm\n\nChange-Id: Ifd429b91a14adb50c95376978d9e89fa3aec7834\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5823496\nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nReviewed-by: Li-Yu Yu \nCommit-Queue: Hung-Hsien Chen ","shortMessageHtmlLink":"CRAS: move DSP input effect blocking into S2."}},{"before":"75c4f25aa0604bd981b2cb3fccabdd85bedcab05","after":"90235d26e603d428dcaeee3d60ad0656bed4406c","ref":"refs/heads/main","pushedAt":"2024-08-28T11:30:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"s2: Determine beamforming DLC requirement based on config\n\nDuring development beamforming DLCs are swapped out with\nprocessing plugins with a hard coded path. In that case\nwe don't need to wait for the DLC to be available.\n\nFigure out the required DLCs by parsing the config file.\n\nFIXED=b:356757845\nTEST=audio_diagnostics with modified /etc/cras/processor/beamforming.txtpb\n\nChange-Id: I5738f6a33a0b7a020545c0b3f7c55c91bf6211d5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5802748\nReviewed-by: Cranel W \nCommit-Queue: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com ","shortMessageHtmlLink":"s2: Determine beamforming DLC requirement based on config"}},{"before":"27b99b4902535c6cc8e05f00f0f79252599f0940","after":"75c4f25aa0604bd981b2cb3fccabdd85bedcab05","ref":"refs/heads/main","pushedAt":"2024-08-27T17:23:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"CRAS: Print sleep_interval_ts\n\nsleep_interval_ts may be changed by the rate estimater.\n\nBUG=None\nTEST=check audio thread log\n\nChange-Id: I9e8e1d5d0446df853d37d0f4c1484d4eadfe0316\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5816148\nTested-by: Yu-Hsuan Hsu \nReviewed-by: Li-Yu Yu \nAuto-Submit: Yu-Hsuan Hsu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nCommit-Queue: Yu-Hsuan Hsu ","shortMessageHtmlLink":"CRAS: Print sleep_interval_ts"}},{"before":"8ba89ce0176e30541763d88fc432ab93615e47bb","after":"27b99b4902535c6cc8e05f00f0f79252599f0940","ref":"refs/heads/main","pushedAt":"2024-08-27T11:37:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copybara-service[bot]","name":null,"path":"/apps/copybara-service","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/44061?s=80&v=4"},"commit":{"message":"cras: dsp: Removed unused C files\n\nRemove the C files that have been completely ported into rust codes.\nThese C files have a copy in cras/src/dsp/c and are currently only used\nfor unit tests.\n\nBUG=b:352433455\nTEST=bazel test //...\n\nChange-Id: I05d6a1d4bc41f6a48cd429db7f44298f4a93d97d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5815951\nReviewed-by: Li-Yu Yu \nTested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com \nAuto-Submit: Nathan Lee \nCommit-Queue: Nathan Lee ","shortMessageHtmlLink":"cras: dsp: Removed unused C files"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxNjowOTo0OS4wMDAwMDBazwAAAAS1rG5M","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxNjowOTo0OS4wMDAwMDBazwAAAAS1rG5M","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yN1QxMTozNzoyOS4wMDAwMDBazwAAAASlSY_l"}},"title":"Activity · chromeos/adhd"}