verify only works if package is notarized

clowd · Jul 4, 2022 · bdcc078 · bdcc078
1 parent 27d73f0
commit bdcc078
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Squirrel.CommandLine/OSX/Commands.cs b/src/Squirrel.CommandLine/OSX/Commands.cs
@@ -131,9 +131,11 @@ private static void Pack(PackOptions options)
                 HelperExe.Notarize(zipPath, options.notaryProfile);
             } else if (SquirrelRuntimeInfo.IsOSX && !String.IsNullOrEmpty(options.signAppIdentity)) {
                 HelperExe.CodeSign(options.signAppIdentity, options.signEntitlements, appBundlePath);
-                Log.Warn("Package was signed but will not be notarized. Must supply the --notaryProfile option.");
+                Log.Warn("Package was signed but will not be notarized or verified. Must supply the --notaryProfile option.");
+            } else if (SquirrelRuntimeInfo.IsOSX) {
+                Log.Warn("Package will not be signed or notarized. Requires the --signAppIdentity and --notaryProfile options.");
             } else {
-                Log.Warn("Package will not be signed or notarized. Only supported on OSX with the --signAppIdentity and --notaryProfile options.");
+                Log.Warn("Package will not be signed or notarized. Only supported on OSX.");
             }
 
             // create a portable zip package from signed/notarized bundle

diff --git a/src/Squirrel.CommandLine/OSX/HelperExe.cs b/src/Squirrel.CommandLine/OSX/HelperExe.cs
@@ -44,15 +44,18 @@ public static void CodeSign(string identity, string entitlements, string filePat
 
             Console.WriteLine(InvokeAndThrowIfNonZero("codesign", args, null));
 
+            Log.Info("codesign completed successfully");
+        }
+
+        public static void SpctlAssess(string filePath)
+        {
             var args2 = new List<string> {
                 "--assess",
                 "-vvvv",
                 filePath
             };
 
             Console.WriteLine(InvokeAndThrowIfNonZero("spctl", args2, null));
-
-            Log.Info("codesign completed successfully");
         }
 
         [SupportedOSPlatform("osx")]