Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Setup error dialog and logging can be greatly improved #13

Closed
caesay opened this issue Dec 12, 2021 · 1 comment
Closed

Setup error dialog and logging can be greatly improved #13

caesay opened this issue Dec 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@caesay
Copy link
Member

caesay commented Dec 12, 2021

DisplayErrorMessage can be called with either no logFile, or with a path to a logFile that does not exist. In both of those cases, a modal is shown with the buttons Open Setup Log and Close - but clicking Open Setup Log does nothing.

Fix:

  • If there is no log file provided, or the file does not exist, the Open Setup Log button should not appear.
  • If Update.exe --install is the thing that failed, we should link up to that log file. (maybe, we specify a log file location via a command line argument when starting Update.exe?)
  • Review logging in Setup.exe more generally - make sure it is working, being stored in a sensible location, has good coverage etc.
@caesay caesay added the enhancement New feature or request label Dec 12, 2021
@caesay caesay changed the title Setup error dialog can be greatly improved Setup error dialog and logging can be greatly improved Dec 14, 2021
@caesay
Copy link
Member Author

caesay commented Dec 20, 2021

Setup.exe is now an extremely simple shim and does not require any logging. if an error occurs, it will alert the user with a message box containing the specific error that occurred. Setup.exe's only job is to extract Update.exe and run it - after which typical logging can take place.

Additionally, logging from Update.exe has been significantly improved. Rolling log files now ensure that log files never get too large, and get cleaned up after themselves (see 2299ecd)

@caesay caesay closed this as completed Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant