Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

ref(SimpleWebSource): Fix Release Entry source to work with parameter url #141

Closed

Conversation

johanneswanzek
Copy link

When using a Storage URL with parameters (e.g. Azure Blob Storage) getting the release file (/RELEASES) works perfetly. Unfortunatly the downloading of the package doesnt work because it discards all query parameters while building the URI.
Using the same mechanism as GetReleaseFeed by utilizing the Utility.AppendPathToUri makes it work perfectly with parameterized Urls.

@caesay
Copy link
Member

caesay commented Jan 24, 2023

I suspect this will break when an absolute path is provided for a release package. For example:

If sourceBaseUri is https://my.domain/packages and releaseUri is MyPackage-1.0.0.nupkg, then source should be https://my.domain/packages/MyPackage-1.0.0.nupkg. This should work fine.

If sourceBaseUri is https://my.domain/packages and releaseUri is https://my.packages.domain/MyPackage-1.0.0.nupkg, then source should be https://my.packages.domain/MyPackage-1.0.0.nupkg. I suspect this will not work properly after this PR.

Could you add a unit test to cover both of these possibilities and check to see if the latter case works with your change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants