{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":824774914,"defaultBranch":"master","name":"kali","ownerLogin":"copyleftdev","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2024-07-05T23:20:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11798?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1720652265.0","currentOid":""},"activityList":{"items":[{"before":"46034c2c07b5b76bf4c4fedd0ab4a2f5688fc4f8","after":"5e72436ff6f443ce95845f987b06afbcc3048ac0","ref":"refs/heads/master","pushedAt":"2024-07-10T22:58:34.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"Merge pull request #3 from copyleftdev/examples\n\nadding sample script for bash load tests","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2401875289\" data-permission-text=\"Title is private\" data-url=\"https://github.com/copyleftdev/kali/issues/3\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/copyleftdev/kali/pull/3/hovercard\" href=\"https://github.com/copyleftdev/kali/pull/3\">#3</a> from copyleftdev/examples"}},{"before":null,"after":"44d8fc61ca4cb6612ca62e7f4065310bfb0b23fd","ref":"refs/heads/examples","pushedAt":"2024-07-10T22:57:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"adding sample script for bash load tests","shortMessageHtmlLink":"adding sample script for bash load tests"}},{"before":"e6d4c333e71ea66a8438a49e15d4671b66fca708","after":"46034c2c07b5b76bf4c4fedd0ab4a2f5688fc4f8","ref":"refs/heads/master","pushedAt":"2024-07-10T14:26:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"upated readme","shortMessageHtmlLink":"upated readme"}},{"before":"6d8891c31356e51e6ff5b067c0f783eb86936585","after":"e6d4c333e71ea66a8438a49e15d4671b66fca708","ref":"refs/heads/master","pushedAt":"2024-07-10T03:51:17.000Z","pushType":"pr_merge","commitsCount":8,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"Merge pull request #2 from copyleftdev/bias\n\n#### Changes:\r\n- **Added overflow check to `parse_hosts_and_biases` function:**\r\n  - Introduced a `total_bias` variable using `u64` to safely sum the biases and avoid overflow.\r\n  - Added a constant `MAX_BIAS` to represent the maximum allowable total bias (`u32::MAX`).\r\n  - Updated logic to check if the total bias exceeds `MAX_BIAS` and return an error if it does.\r\n  - Included a check to ensure bias values are greater than 0, returning an error otherwise.\r\n\r\n- **Updated test case `test_bias_overflow_parsing`:**\r\n  - Modified the test case to use bias values that would result in an overflow condition.\r\n  - Verified that `Config::try_parse_from` correctly returns an error when the total bias exceeds the allowable limit.\r\n\r\n#### Testing:\r\n- **Tested `parse_hosts_and_biases` function:**\r\n  - Validated correct parsing of valid bias values.\r\n  - Confirmed that invalid bias values (e.g., non-numeric or zero) result in appropriate error messages.\r\n  - Ensured that scenarios where the total bias exceeds `u32::MAX` result in an error.\r\n\r\n- **Tested other functions for regressions:**\r\n  - Ran existing unit tests to confirm no unintended side effects or regressions in functionality.\r\n\r\n#### Summary:\r\n- This update improves the robustness of the `parse_hosts_and_biases` function by adding defensive programming checks for bias overflow. The changes ensure that users are informed of configuration errors when bias values exceed allowable limits, thereby preventing potential runtime issues.\r\n\r\n---\r\n\r\nThis detailed commit note should help reviewers understand the changes made, the reasons behind them, and the testing conducted to ensure correctness.","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2399683133\" data-permission-text=\"Title is private\" data-url=\"https://github.com/copyleftdev/kali/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/copyleftdev/kali/pull/2/hovercard\" href=\"https://github.com/copyleftdev/kali/pull/2\">#2</a> from copyleftdev/bias"}},{"before":"e36d1c3e7496742b043c99648b7b3f0998d3dedb","after":"6a072c19c3f04a5a762c212f739ddfb65e472d38","ref":"refs/heads/bias","pushedAt":"2024-07-10T03:48:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"update bias logic and updates test","shortMessageHtmlLink":"update bias logic and updates test"}},{"before":"5dc1706bec8b53a8690580a01cb155101211a15a","after":"e36d1c3e7496742b043c99648b7b3f0998d3dedb","ref":"refs/heads/bias","pushedAt":"2024-07-10T00:49:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"perfectv2","shortMessageHtmlLink":"perfectv2"}},{"before":"3cbfad2a5fb9b97f8e37211ff4b4aeb9d7868c53","after":"5dc1706bec8b53a8690580a01cb155101211a15a","ref":"refs/heads/bias","pushedAt":"2024-07-09T22:01:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"perfectv1","shortMessageHtmlLink":"perfectv1"}},{"before":"4dd1139069dd834b48024a57c2aac2731811be0c","after":"3cbfad2a5fb9b97f8e37211ff4b4aeb9d7868c53","ref":"refs/heads/bias","pushedAt":"2024-07-09T21:16:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"v3","shortMessageHtmlLink":"v3"}},{"before":null,"after":"4dd1139069dd834b48024a57c2aac2731811be0c","ref":"refs/heads/bias","pushedAt":"2024-07-09T14:56:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"lnws","shortMessageHtmlLink":"lnws"}},{"before":"ed39382c9b3d0cbb4b09894bf63421ea4ffbe158","after":"6d8891c31356e51e6ff5b067c0f783eb86936585","ref":"refs/heads/master","pushedAt":"2024-07-09T14:09:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"updated clap","shortMessageHtmlLink":"updated clap"}},{"before":"1afbe4a6b27e51de4659cc79e149201b29ad9066","after":"ed39382c9b3d0cbb4b09894bf63421ea4ffbe158","ref":"refs/heads/master","pushedAt":"2024-07-08T19:21:42.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"Merge pull request #1 from copyleftdev/feature/realtime-stats\n\nadded reporting","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2396383350\" data-permission-text=\"Title is private\" data-url=\"https://github.com/copyleftdev/kali/issues/1\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/copyleftdev/kali/pull/1/hovercard\" href=\"https://github.com/copyleftdev/kali/pull/1\">#1</a> from copyleftdev/feature/realtime-stats"}},{"before":null,"after":"7e07447b4030df5014d92c15c9f65cea6a71f1ab","ref":"refs/heads/feature/realtime-stats","pushedAt":"2024-07-08T18:15:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"added reporting","shortMessageHtmlLink":"added reporting"}},{"before":"c9ad0a37e696e6e5105619da6ad1a845c8eac4a3","after":"1afbe4a6b27e51de4659cc79e149201b29ad9066","ref":"refs/heads/master","pushedAt":"2024-07-08T16:46:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"update ingnore patterns","shortMessageHtmlLink":"update ingnore patterns"}},{"before":"38316be77e4b5b5d42796e9c84df8b812b3edb53","after":"c9ad0a37e696e6e5105619da6ad1a845c8eac4a3","ref":"refs/heads/master","pushedAt":"2024-07-08T05:26:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"updated readme","shortMessageHtmlLink":"updated readme"}},{"before":"3f8da0f3b31f792c650790837779c10689256ef7","after":"38316be77e4b5b5d42796e9c84df8b812b3edb53","ref":"refs/heads/master","pushedAt":"2024-07-08T03:30:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"Update README.md","shortMessageHtmlLink":"Update README.md"}},{"before":"e7a6da8a9ada99af081c62df119035d9618c2ae6","after":"3f8da0f3b31f792c650790837779c10689256ef7","ref":"refs/heads/master","pushedAt":"2024-07-07T21:42:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"optimized rps logic","shortMessageHtmlLink":"optimized rps logic"}},{"before":"ac60e522179a63a8d60d6ffcbd905d7443a2228b","after":"e7a6da8a9ada99af081c62df119035d9618c2ae6","ref":"refs/heads/master","pushedAt":"2024-07-06T21:42:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"Create rust.yml","shortMessageHtmlLink":"Create rust.yml"}},{"before":null,"after":"ac60e522179a63a8d60d6ffcbd905d7443a2228b","ref":"refs/heads/master","pushedAt":"2024-07-06T21:37:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"copyleftdev","name":"L337[e9aa5768]SIGMA","path":"/copyleftdev","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11798?s=80&v=4"},"commit":{"message":"added tests","shortMessageHtmlLink":"added tests"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEfEBGWQA","startCursor":null,"endCursor":null}},"title":"Activity · copyleftdev/kali"}