Use ArgumentException.ThrowIfNullOrWhitespace

[danmoseley]

implemented in dotnet/runtime#86007 and should flow here in a few days.

similar effort for ThrowIfNull #43482

there have been several of these throw helpers added in the core libraries this release, maybe there's others that are relevant to us. perhaps someone would like to take a look?

[danmoseley]

@amcasey do we have an area like runtime has 'area-meta' for cross codebase changes?

[amcasey]

We ended up concluding that was out of scope for our initial clean-up push since it required more coordination. My personal feeling is that that probably wouldn't be an "area-" since (I understand) those labels are applied automatically. I have seen issues tagged with more than one area. Alternatively, some cross-team pushes get prefix-less labels.

[danmoseley]

that probably wouldn't be an "area-" since (I understand) those labels are applied automatically

I have no opinion but FYI, that isn't a problem. dotnet/runtime has area-meta and it's predicted (probably with lower accuracy). @jeffhandley how well do you think that works -- thoughts about pros/cons of multiple area labels (which is forbidden in dotnet/runtime)?

[jeffhandley]

In dotnet/runtime, area-meta label works okay. It ends up being a "junk drawer" label to catch all things that span multiple areas, represent cross-area/cross-team epics, as well as epics and stories that span multiple repos.

Where its value surfaces is that it makes accountability clearer: No individual area owners are expected to track the area-meta issues; instead, the leads follow up on them. Getting those issues out of the way for typical area ownership responsibilities helped the team.

[wcontayon]

Hi @danmoseley can I take a look and submit a PR on that issue 🙂 ?

[danmoseley]

@wcontayon Go for it

[divyeshio]

Hi, I would like to work on this