-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ArgumentException.ThrowIfNullOrWhitespace #48185
Comments
@amcasey do we have an area like runtime has 'area-meta' for cross codebase changes? |
We ended up concluding that was out of scope for our initial clean-up push since it required more coordination. My personal feeling is that that probably wouldn't be an "area-" since (I understand) those labels are applied automatically. I have seen issues tagged with more than one area. Alternatively, some cross-team pushes get prefix-less labels. |
I have no opinion but FYI, that isn't a problem. dotnet/runtime has area-meta and it's predicted (probably with lower accuracy). @jeffhandley how well do you think that works -- thoughts about pros/cons of multiple area labels (which is forbidden in dotnet/runtime)? |
In dotnet/runtime, Where its value surfaces is that it makes accountability clearer: No individual area owners are expected to track the |
Hi @danmoseley can I take a look and submit a PR on that issue 🙂 ? |
@wcontayon Go for it |
Hi, I would like to work on this |
implemented in dotnet/runtime#86007 and should flow here in a few days.
similar effort for ThrowIfNull #43482
there have been several of these throw helpers added in the core libraries this release, maybe there's others that are relevant to us. perhaps someone would like to take a look?
The text was updated successfully, but these errors were encountered: