Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid 'Opt' suffix in nullable-enabled code #2920

Closed
sharwell opened this issue Oct 9, 2019 · 2 comments · Fixed by #3352
Closed

Avoid 'Opt' suffix in nullable-enabled code #2920

sharwell opened this issue Oct 9, 2019 · 2 comments · Fixed by #3352
Labels
Area-Roslyn.Diagnostics.Analyzers Category-CodeStyle Feature Request

Comments

@sharwell
Copy link
Member

sharwell commented Oct 9, 2019

This will help with cleaning up the code base after nullable reference types is adopted.

dotnet/roslyn#39053 (comment)
@sharwell sharwell mentioned this issue Oct 9, 2019
Merged
@Evangelink
Copy link
Member

@sharwell I have a couple of questions related to this rule:

  1. Shall we restrict the analysis to parameters and fields?

  2. Is there a nice way to detect the nullable option?

  3. Is it a roslyn-specific rule or do you think this shall be more global?

@Evangelink
Copy link
Member

I have noticed the NullableSemanticAnalysisEnabled property but it's internal.

@Evangelink Evangelink mentioned this issue Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Roslyn.Diagnostics.Analyzers Category-CodeStyle Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RS0046: Avoid Opt suffix in nullable-enabled code Evangelink/roslyn-analyzers
2 participants
@sharwell @Evangelink