Add ArgumentKind.ParamCollection
#72221
Conversation
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review |
| @@ -345,7 +345,7 @@ private static ArgumentKind GetArgumentKind(BoundExpression argument, ref BitVec | |||
| } | |||
| else if (argument.IsParamsCollection) | |||
| { | |||
| argumentKind = ArgumentKind.ParamArray; | |||
| argumentKind = argument.Type?.IsSZArray() == true ? ArgumentKind.ParamArray : ArgumentKind.ParamCollection; | |||
There was a problem hiding this comment.
I thought that IsParamsCollection would only be true if it was actually a params collection, and IsParamsArray would be true in the other case, with IsParams being the catch-all. Is that just not implemented yet?
There was a problem hiding this comment.
I thought that
IsParamsCollectionwould only be true if it was actually a params collection, andIsParamsArraywould be true in the other case, withIsParamsbeing the catch-all. Is that just not implemented yet?
This is not an IOperation API and is not a property on IParameterSymbol. Bound nodes do not have IsParamsArray or IsParams properties. The internal IsParamsCollection property covers both cases.
There was a problem hiding this comment.
I see. It may be worth a refactoring to standardize them at some point then.
There was a problem hiding this comment.
It may be worth a refactoring to standardize them at some point then.
I do not think it is needed.
| DefaultValue = 0x3, | ||
|
|
||
| /// <summary> | ||
| /// Argument is a param collection created by compilers for the matching C# params y parameter. |
There was a problem hiding this comment.
Not sure what the y parameter at the end here is?
There was a problem hiding this comment.
Not sure what the
y parameterat the end here is?
I guess the remainder artifact of "ParamArray"
AlekseyTs
merged commit 05cf517
into
dotnet:features/ParamsCollections
Related #72222.