-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Covariant Returns Feature #35308
Merged
Merged
Covariant Returns Feature #35308
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bf7501f
Covariant Returns Feature: Allowing return types on MethodImpl to be …
fef49b2
Adding the missing .ctor methods to the various types
f10119d
Perform covariant return signature matching only after an exact match…
8d5d87e
Add test coverage for implicit override with less derived return type
a14af6f
Change ValidateMethodImplRemainsInEffect attribute to apply to methods
0e4e472
Moving covariant return type checking to the final stage of type load…
698eafb
Rename attribute and reference it from System.Runtime instead of S.P.C
6848c40
Add test coverage for interface cases.
5a85da8
Handling for struct cases, and adding test coverage for it.
89bb5c3
Small test fixes
cbecf78
Fix consistency issue with the way the RequireMethodImplToRemainInEff…
1154b90
Support covariant returns and slot unifications in crossgen2
f97b9de
some CR feedback
1329fea
Add unit test coverage for delegates
997074f
Fix handling of covariant and contravariant generic interfaces
janvorli ed9fb4c
Added test cases to interfaces unit test
janvorli 6eaaa1a
Fix Nullable handling and add more tests
janvorli 688c263
Reflect Fadi's feedback - limit the GCX_COOP scope
janvorli 3636d03
Reflect PR feedback
janvorli c05f075
Rename the attribute to PreserveBaseOverridesAttribute
janvorli 7ccd3ed
Disable covariant returns tests on Mono for now
janvorli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to move GCX_COOP inside the IsCompatibleWith helper when needed (not all checks need this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Fadi, it makes sense. I've made that change. Btw, I am still using your branch for finishing this work, so I'd like to ask you to keep it until it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jan, yes I’ll keep the branch around