From 759a339f687037b1492ff5e6774b2263bcada062 Mon Sep 17 00:00:00 2001
From: Jan Verbeek <jan.verbeek@posteo.nl>
Date: Tue, 4 Jun 2024 17:29:39 +0200
Subject: [PATCH] Ignore NO_COLOR if set to empty string

Environment variables can have no value at all or they can have the
empty string as a value. We used to disable color if `$NO_COLOR` were
set at all, regardless of its value, but as of
https://github.com/jcs/no_color/commit/99f90e27d0fac6a34d07998f8f577e1f2f620c61
we should ignore empty strings (and this makes more sense).

Result: `NO_COLOR= xh` now allows colors.
---
 src/buffer.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/buffer.rs b/src/buffer.rs
index 5c29d5ac..5aa18b5e 100644
--- a/src/buffer.rs
+++ b/src/buffer.rs
@@ -312,7 +312,7 @@ impl Buffer {
             // Based on termcolor's logic for ColorChoice::Auto
             if cfg!(test) {
                 Pretty::All
-            } else if var_os("NO_COLOR").is_some() {
+            } else if var_os("NO_COLOR").is_some_and(|val| !val.is_empty()) {
                 Pretty::Format
             } else {
                 match var_os("TERM") {