-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial public version #1
Conversation
dcterms:license. They should be fixed in emmocheck.
…master' Update readme according to marketplace template See merge request ontology/domains/crystallography!1
… failures + added some debugging output to the before_script
Load local version of EMMO when running emmocheck in .gitlab-ci.yml See merge request ontology/domains/crystallography!3
Improved annotations for species and constituent. See merge request ontology/domains/crystallography!2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to get in and iterate on if needed 👍
I've made a few minor comments, they're not crucial at all so will approve and let it be up to @jesper-friis what to do with the comments :)
run: | | ||
pip install EMMO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the pipe (also below), or are you future-proofing for more lines? :)
run: | | |
pip install EMMO | |
run: pip install EMMO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. It is just the syntax used in the templates by GitHub
run: | | ||
emmocheck --local --verbose --check-imported emmo.owl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: | | |
emmocheck --local --verbose --check-imported emmo.owl | |
run: emmocheck --local --verbose --check-imported emmo.owl |
Status | ||
------ | ||
- [ ] Proposal | ||
- [X] accepted, under development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [X] accepted, under development | |
- [X] Accepted, under development |
------ | ||
- [ ] Proposal | ||
- [X] accepted, under development | ||
- [ ] official |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ] official | |
- [ ] Official |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points.
Looks good, took only a few minutes for reasoning in Protege |
I don't feel comfortable with a candidate EMMO domain ontology that depends on an EMMO version that is not part of the official repository. We should implement in the EMMO official branches the EMMO-marketplace feature that this domain ontology needs. The IRI http://emmo.info/emmo/marketplace-1.0.1 is not working, so the domain ontology has no top level foundation. |
I merging so we have all in the master! |
Initial public version of the crystallography domain ontology. The README file has been updated with Adham's table to reflect the status as a non-official EMMO domain ontology