Initial public version #1
Conversation
dcterms:license. They should be fixed in emmocheck.
…master' Update readme according to marketplace template See merge request ontology/domains/crystallography!1
… failures + added some debugging output to the before_script
Load local version of EMMO when running emmocheck in .gitlab-ci.yml See merge request ontology/domains/crystallography!3
Improved annotations for species and constituent. See merge request ontology/domains/crystallography!2
There was a problem hiding this comment.
Good to get in and iterate on if needed 👍
I've made a few minor comments, they're not crucial at all so will approve and let it be up to @jesper-friis what to do with the comments :)
| run: | | ||
| pip install EMMO |
There was a problem hiding this comment.
No need for the pipe (also below), or are you future-proofing for more lines? :)
| run: | | |
| pip install EMMO | |
| run: pip install EMMO |
There was a problem hiding this comment.
You are right. It is just the syntax used in the templates by GitHub
| run: | | ||
| emmocheck --local --verbose --check-imported emmo.owl |
There was a problem hiding this comment.
| run: | | |
| emmocheck --local --verbose --check-imported emmo.owl | |
| run: emmocheck --local --verbose --check-imported emmo.owl |
| Status | ||
| ------ | ||
| - [ ] Proposal | ||
| - [X] accepted, under development |
There was a problem hiding this comment.
| - [X] accepted, under development | |
| - [X] Accepted, under development |
| ------ | ||
| - [ ] Proposal | ||
| - [X] accepted, under development | ||
| - [ ] official |
There was a problem hiding this comment.
| - [ ] official | |
| - [ ] Official |
|
Looks good, took only a few minutes for reasoning in Protege |
|
I don't feel comfortable with a candidate EMMO domain ontology that depends on an EMMO version that is not part of the official repository. We should implement in the EMMO official branches the EMMO-marketplace feature that this domain ontology needs. The IRI http://emmo.info/emmo/marketplace-1.0.1 is not working, so the domain ontology has no top level foundation. |
|
I merging so we have all in the master! |
Initial public version of the crystallography domain ontology. The README file has been updated with Adham's table to reflect the status as a non-official EMMO domain ontology