Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to emmo 1.0.0 alpha2 #2

Merged
merged 9 commits into from
Oct 21, 2020
Merged

Conversation

jesper-friis
Copy link
Collaborator

No description provided.

@jesper-friis
Copy link
Collaborator Author

A fix for the failing tests (for all domain ontologies) has been pushed to emmo-python. That needs to be published as a new pypi package for the tests to pass. It is also possible to temporarily fix this by skipping the test_quantity_dimension test, but I prefer the first solution.

@francescalb
Copy link
Contributor

I have a problem when getting the submodule, it calls the 1.0.0-beta version
git submodule update
gives me a version of emmo.owl with this header:

<rdf:RDF xmlns="http://emmo.info/emmo#"
xml:base="http://emmo.info/emmo"
xmlns:isq="http://emmo.info/emmo/middle/isq#"
xmlns:owl="http://www.w3.org/2002/07/owl#"
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:xml="http://www.w3.org/XML/1998/namespace"
xmlns:xsd="http://www.w3.org/2001/XMLSchema#"
xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#"
xmlns:skos="http://www.w3.org/2004/02/skos/core#"
xmlns:dcterms="http://purl.org/dc/terms/"
xmlns:annotations="http://emmo.info/emmo/top/annotations#">
<owl:Ontology rdf:about="http://emmo.info/emmo">
<owl:versionIRI rdf:resource="http://emmo.info/emmo/1.0.0-beta"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/top"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/holistic"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/isq"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/manufacturing"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/materials"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/models"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/perceptual"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/physicalistic"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/properties"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/reductionistic"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/semiotics"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/siunits"/>
<owl:imports rdf:resource="http://emmo.info/emmo/1.0.0-beta/middle/units-extension"/>
<dcterms:abstract xml:lang="en">European Materials & Modelling Ontology (EMMO)

@francescalb
Copy link
Contributor

A fix for the failing tests (for all domain ontologies) has been pushed to emmo-python. That needs to be published as a new pypi package for the tests to pass. It is also possible to temporarily fix this by skipping the test_quantity_dimension test, but I prefer the first solution.

Is that fix ready for a pull request?

@jesper-friis
Copy link
Collaborator Author

Yes, it is included in EMMO-python PR #53.

@francescalb
Copy link
Contributor

Yes, it is included in EMMO-python PR #53.

There was still some things to fix. Added now and merged.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is accepted by emmocheck as well

@francescalb francescalb merged commit ca6f20d into master Oct 21, 2020
@francescalb francescalb deleted the update-to-emmo-1.0.0-alpha2 branch October 21, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants