-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to emmo 1.0.0 alpha2 #2
Conversation
…main-crystallography into update-to-emmo-1.0.0-alpha2
A fix for the failing tests (for all domain ontologies) has been pushed to emmo-python. That needs to be published as a new pypi package for the tests to pass. It is also possible to temporarily fix this by skipping the test_quantity_dimension test, but I prefer the first solution. |
Is that fix ready for a pull request? |
Yes, it is included in EMMO-python PR #53. |
There was still some things to fix. Added now and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and is accepted by emmocheck as well
No description provided.