Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed IRI to EMMO to a valid URL such that we do not depend on the catalog file #31

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Changed IRI to EMMO to a valid URL such that we do not depend on the catalog file #31

merged 3 commits into from
Apr 27, 2021

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Apr 25, 2021 •
edited by CasperWA

Fixes #37

CasperWA
CasperWA approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine for me. Thanks @jesper-friis.

However, as a note, this file probably needs to be moved to the new domain-crystallography repository - but that's for a later time.

@CasperWA CasperWA merged commit 8b7af73 into main Apr 27, 2021
@CasperWA CasperWA deleted the full-url-to-emmo branch April 27, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IRI to EMMO-Chemistry is not a valid URL
2 participants
@jesper-friis @CasperWA