Remove Owlready2 as a direct dependency #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good question. Explicit dependencies on specific versions is important. However, since EMMO-python has already an explicit dependency on Owlready2 (updated to Owlready2=0.30) we have a chain of explicit dependencies. I think it will be easier to maintain to only specify the version of Owlready2 in EMMO-python |
jesper-friis
previously approved these changes
Apr 27, 2021
Get it through EMMO instead.
No files updated when running `pre-commit run --all-files`.
CasperWA
force-pushed
the
fix_35_owlready2
branch
from
edbd9e7
to
9759ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35.
As stated in #35, we can remove Owlready2 as a dependency and rely on EMMO-Python to get it instead.
Note: Although, we do use Owlready2 directly in the
generate_cif.pyfile. I have gotten second thoughts on this. Perhaps we should instead report this in the EMMO-Python repository and ensure a broader Owlready2 dependency version range? @jesper-friis and @francescalb what do you think?This PR also updates the
pre-commithooksblackandflake8. No files were updated after runningpre-commit run --all-filesusing the updated versions.