Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed table and row to loop and packet, respectively #40

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Renamed table and row to loop and packet, respectively #40

merged 1 commit into from
Apr 28, 2021

Conversation

jesper-friis
Copy link
Collaborator

Refixed renaming of table and row

francescalb
francescalb approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, this fixes the problem I had with generate_cif.py

@jesper-friis jesper-friis merged commit 4fe891f into main Apr 28, 2021
@jesper-friis jesper-friis deleted the loop-and-packet branch April 28, 2021 19:46
@francescalb francescalb restored the loop-and-packet branch April 28, 2021 19:46
@francescalb francescalb deleted the loop-and-packet branch April 28, 2021 19:46
@CasperWA
Copy link
Contributor

CasperWA commented Apr 29, 2021 •
edited

Good, this fixes the problem I had with generate_cif.py

What problem was this? Please create GitHub issues or outline the issue in the PR that fixes it so that we be aware of possible problems :)

Edit: Though I'm guessing this was the line? 😅

@francescalb
Copy link
Contributor

The problem was that it did not find _TABLE and _ROW, whichwas because it was decided to use _LOOP and _PACKET instead.
We got a bit carried away as we found this problem while wotking on something else and fixed it right away, and as a result forgot to make an issue. I will make sure to improve on this. Sorry.

@CasperWA
Copy link
Contributor

CasperWA commented Apr 29, 2021 •
edited

The problem was that it did not find _TABLE and _ROW, whichwas because it was decided to use _LOOP and _PACKET instead.
We got a bit carried away as we found this problem while wotking on something else and fixed it right away, and as a result forgot to make an issue. I will make sure to improve on this. Sorry.

Cheers 🙂 Just an explanation in the PR would be good enough for such fast fixes, I should think.
And thanks for the quick-fix! 😃 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

@CasperWA CasperWA Awaiting requested review from CasperWA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jesper-friis @CasperWA @francescalb