Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse dicfile as string if not existing locally #41

Merged
merged 2 commits into from
May 14, 2021
Merged

Parse dicfile as string if not existing locally #41

merged 2 commits into from
May 14, 2021

Conversation

CasperWA
Copy link
Contributor

The dic2owl CLI parses the input as a pathlib.Path object, meaning if a cif_core.dic is passed, it will resolve to be /path/to/current/dir/cif_core_dic, and this should only happen if the file already exists, otherwise it should download the dictionary from the COMCIFS/cif_core repository.

@CasperWA CasperWA added bug Something isn't working dic2owl Issue or PR related specifically to the dic2owl Python package labels May 10, 2021
francescalb
francescalb approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly.

@CasperWA CasperWA merged commit affa867 into main May 14, 2021
@CasperWA CasperWA deleted the fix_request_errors branch May 14, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

@jesper-friis jesper-friis Awaiting requested review from jesper-friis

Assignees
No one assigned
Labels
bug Something isn't working dic2owl Issue or PR related specifically to the dic2owl Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CasperWA @francescalb