-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue4 import emmo-inferred from official repo #5
Issue4 import emmo-inferred from official repo #5
Conversation
I have removed emocheck in the workflow for now as it fails. Please comment on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we not run emmocheck
on this now?
Ah, this is why. From this check run it seems |
@francescalb This is fine now and can be merged, right? Or do you want to close it in favor of #6? |
I think we can merge it, but it is blocked? |
Try turning |
Had to fix the import and skip test_quantity_dimension to have it work.
Added physicalDimensions and it should work now. @CasperWA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enabling emmocheck
and making it work again @francescalb !
This is good to go from my end now 👍 🚀
Now importing emmo-1.0.0-alpha2 as emmo-inferred directly from official repo instead of including emmo a submodule.
Fixes #4