-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to emmo 1.0.0 beta and convert to turtle #6
Conversation
The additional file from_chemistry.ttl is because that the branch https://github.com/emmo-repo/EMMO/tree/Chemistry that Emanuele is working on is not yet merged to 1.0.0-beta. |
catalog-v001.xml
Outdated
<uri name="http://emmo.info/crystallography/0.0.1/crystallography" uri="./crystallography.owl"/> | ||
<uri name="http://emmo.info/emmo/1.0.0-beta/emmo-inferred" uri="https://emmo-repo.github.io/versions/1.0.0-beta/emmo-inferred.ttl"/> | ||
<uri name="http://emmo.info/emmo/from-chemistry" uri="from-chemistry.ttl"/> | ||
<uri name="file:///home/friisj/Private/prosjekter/EMMC/EMMO/.github/pages/versions/1.0.0-beta/_result_ontology.owl" uri="https://emmo-repo.github.io/versions/1.0.0-beta/emmo-inferred.ttl"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are asking for an ontology on your local machine here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are asking for an ontology on your local machine here
I see, it is just the ontology iri of the inferred ontology. It works right now, but will very easily break. Better to make new inferred version with a better iri.
There is a whole set of objectProperties that have the wrong namespace which come up when opening in protege. They are duplicates (same IRI) as properly defined ObjectProperties (e.g. hasPart). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it isimportant that the check does not fail before merging master
.github/workflows/ci_emmocheck.yml
Outdated
@@ -26,4 +26,4 @@ jobs: | |||
|
|||
- name: Check EMMO | |||
run: | | |||
emmocheck --local --verbose --check-imported crystallography.owl | |||
emmocheck --url-from-catalog --verbose crystallography.owl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emmocheck --url-from-catalog --verbose crystallography.owl | |
#emmocheck --url-from-catalog --verbose crystallography.owl |
I suggest removing emmocheck for now, until support for ttl is included in emmopython
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jesper-friis !
I would probably hold off merging this until EMMO (and EMMO-Python) has been updated to use Turtle - unless you insist on continuing the development of this ontology in Turtle (and the conversion from OWL to Turtle is cumbersome), otherwise, continuing development in the OWL format and converting to Turtle later, i.e., updating this PR, would be better.
The main reason for this is the drop of an essential CI check and the necessity to use refer to local files.
Final question, why is to_emmo.owl
added? Should it also not be Turtle and is it not part of the EMMO ontology itself?
Closes #7