Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cif #60

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Add test cif #60

merged 6 commits into from
Aug 30, 2021

Conversation

vaitkus
Copy link
Collaborator

@vaitkus vaitkus commented Aug 27, 2021

This PR contains several CIF files that should prove useful for testing purposes.

Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @vaitkus !

I've added a single suggested change to split up the sentences in the markdown, making future git diffs easier to understand, while not actually changing the rendered content.

I wanted to a comment here about adding a bit more info about the download-cifs script, but after re-reading the README, I don't think it's necessary, honestly.

So yeah, I'll merge this if you accept the suggested changes (or have a good reason not to).

test-cif/README.md Outdated Show resolved Hide resolved
Co-authored-by: Casper Welzel Andersen <[email protected]>
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @vaitkus !

@CasperWA CasperWA merged commit 8ae9806 into emmo-repo:main Aug 30, 2021
@vaitkus vaitkus deleted the add-test-cif branch August 30, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants