Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed importing EMMO #8

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Fixed importing EMMO #8

merged 4 commits into from
Jan 4, 2021

Conversation

jesper-friis
Copy link
Collaborator

No description provided.

@CasperWA
Copy link
Contributor

CasperWA commented Jan 4, 2021

Isn't the issue here still that emmo-inferred has not been created in the emmo-repo/EMMO repository since emmo.info redirects to raw files there?
At least I still get a 404 Not Found for http://emmo.info/emmo-inferred/1.0.0-beta.

@jesper-friis
Copy link
Collaborator Author

You are right, this doesn't solve the issue #9 - only that I can open crystallography.ttl locally.
We use the catalog file to map http://emmo.info/emmo-inferred/1.0.0-beta a resolvable. The issue is of cause that Protege only looks at the catalog file when we open the ontology locally, not from the web.

I guess this PR should be updated with http://emmo.info/emmo-inferred/1.0.0-beta replaced with an ugly, but resolvable url. Correct?

@jesper-friis
Copy link
Collaborator Author

I actually think that this works. At least I can load https://raw.githubusercontent.com/emmo-repo/domain-crystallography/fix-imported-emmo/crystallography.ttl from URL in protege.

The reason for the failing check is more an issue with EMMO-python - we are working on it...

@jesper-friis jesper-friis linked an issue Jan 4, 2021 that may be closed by this pull request
catalog-v001.xml Outdated
Comment on lines 6 to 7
<uri name="http://emmo.info/emmo/from-chemistry" uri="from-chemistry.ttl"/>
<uri name="https://raw.githubusercontent.com/emmo-repo/domain-crystallography/master/from-chemistry.ttl" uri="from-chemistry.ttl"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<uri name="http://emmo.info/emmo/from-chemistry" uri="from-chemistry.ttl"/>
<uri name="https://raw.githubusercontent.com/emmo-repo/domain-crystallography/master/from-chemistry.ttl" uri="from-chemistry.ttl"/>
<uri name="http://emmo.info/emmo/from-chemistry" uri="https://raw.githubusercontent.com/emmo-repo/domain-crystallography/master/from-chemistry.ttl"/>

How about this for using the online from-chemistry.ttl resource? Or do you explicitly want to use the local one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catalog file is only read (at least by Protege and emmo-python) when you are loading the ontology locally. Since we in this case already have from-chemistry.ttl available locally it is little faster to use that.

Line 6 is not used and could be dropped.

Line 7 loads the from-chemistry.ttl locally as explained above. Could be dropped too if we always want to load from web as explained above. I have no strong opinions, but would prefer to keep it.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jesper, to keep the catalog-file so that importing locally is an option

@jesper-friis jesper-friis merged commit c4f8090 into master Jan 4, 2021
@jesper-friis jesper-friis deleted the fix-imported-emmo branch January 4, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that crystallography can be opened from url in Protege
3 participants