-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed importing EMMO #8
Conversation
Isn't the issue here still that |
You are right, this doesn't solve the issue #9 - only that I can open crystallography.ttl locally. I guess this PR should be updated with http://emmo.info/emmo-inferred/1.0.0-beta replaced with an ugly, but resolvable url. Correct? |
I actually think that this works. At least I can load https://raw.githubusercontent.com/emmo-repo/domain-crystallography/fix-imported-emmo/crystallography.ttl from URL in protege. The reason for the failing check is more an issue with EMMO-python - we are working on it... |
catalog-v001.xml
Outdated
<uri name="http://emmo.info/emmo/from-chemistry" uri="from-chemistry.ttl"/> | ||
<uri name="https://raw.githubusercontent.com/emmo-repo/domain-crystallography/master/from-chemistry.ttl" uri="from-chemistry.ttl"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<uri name="http://emmo.info/emmo/from-chemistry" uri="from-chemistry.ttl"/> | |
<uri name="https://raw.githubusercontent.com/emmo-repo/domain-crystallography/master/from-chemistry.ttl" uri="from-chemistry.ttl"/> | |
<uri name="http://emmo.info/emmo/from-chemistry" uri="https://raw.githubusercontent.com/emmo-repo/domain-crystallography/master/from-chemistry.ttl"/> |
How about this for using the online from-chemistry.ttl
resource? Or do you explicitly want to use the local one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catalog file is only read (at least by Protege and emmo-python) when you are loading the ontology locally. Since we in this case already have from-chemistry.ttl available locally it is little faster to use that.
Line 6 is not used and could be dropped.
Line 7 loads the from-chemistry.ttl locally as explained above. Could be dropped too if we always want to load from web as explained above. I have no strong opinions, but would prefer to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Jesper, to keep the catalog-file so that importing locally is an option
No description provided.