{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":11131631,"defaultBranch":"main","name":"fbthrift","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-07-02T18:15:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725894202.0","currentOid":""},"activityList":{"items":[{"before":"b4a12ae87c8a844360a5b6e8f93b757fb5677712","after":"3f36d1124a1932e355aa5ee92d5399e74e70ae9a","ref":"refs/heads/main","pushedAt":"2024-09-10T02:00:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Invoke ClientInterceptors::{onRequest,onResponse} for SemiFuture and Future functions\n\nSummary:\nThis is a redo of {D61552180} which was reverted again due to build size regresisons.\n\nIn this diff we focus our hardest to avoid increase in generated code. Seemingly, each (templated) `defer` / `deferValue` generates a bunch of code so we're trying to minimize that here.\n\nReviewed By: sazonovkirill\n\nDifferential Revision: D62213494\n\nfbshipit-source-id: 2a7e6ca39fcdc0c7c49cd9dbdc75e705d16a21d3","shortMessageHtmlLink":"Invoke ClientInterceptors::{onRequest,onResponse} for SemiFuture and …"}},{"before":"46cdbc146124eb36ed9602e571a23b09ba14a0b6","after":"b4a12ae87c8a844360a5b6e8f93b757fb5677712","ref":"refs/heads/main","pushedAt":"2024-09-10T01:40:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix arvr build for TableBasedSerializer\n\nSummary: Fix a shadowed variable error\n\nReviewed By: aristidisp, yoney\n\nDifferential Revision: D62324934\n\nfbshipit-source-id: e5c9aea6ed41994dde624a1f407436d50d324174","shortMessageHtmlLink":"Fix arvr build for TableBasedSerializer"}},{"before":"9d7579fb29ba75c553434d9638753525c860afd2","after":"46cdbc146124eb36ed9602e571a23b09ba14a0b6","ref":"refs/heads/main","pushedAt":"2024-09-10T00:36:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add __dir__ to mutable struct\n\nSummary: Add `__dir__` to `MutableStruct` and parameterise related tests.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D62406523\n\nfbshipit-source-id: d99d8c0c0074fd3ebe0943d8852b23e2ae866772","shortMessageHtmlLink":"Add __dir__ to mutable struct"}},{"before":"a9df4640b38f57060140a42063c2e8d3d6128c3e","after":"9d7579fb29ba75c553434d9638753525c860afd2","ref":"refs/heads/main","pushedAt":"2024-09-10T00:06:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix AnyPatch::encode and AnyPatch::decode\n\nSummary: TSIA\n\nReviewed By: Mizuchi\n\nDifferential Revision: D62412094\n\nfbshipit-source-id: b64fb0e222ed7de95cd3ff5ecfde5be0b442866e","shortMessageHtmlLink":"Fix AnyPatch::encode and AnyPatch::decode"}},{"before":"cf5d97fa34545058a316eb7e50fafae5aca92709","after":"a9df4640b38f57060140a42063c2e8d3d6128c3e","ref":"refs/heads/main","pushedAt":"2024-09-09T23:19:48.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use F14NodeMap for Protocol Object fields\n\nSummary:\n`F14NodeMap` is a better choice since we don't know the field size in advance and this will not lead us to reallocate the values in map. In general we see improvement in deserialization and serialization. The extreme test case of `LargeMixed` show improvement in deserialization but regression in serialization but since deserialization is generally much slower than serialization (~x5), this is a fair trade-off.\n\nbenchmark result:\n// More general -> ~34% improvement in deserialization of ComplexStruct\n//                           -> Slight improvement in serialization in general\n```\n// before\n=============================================================================================\nfbcode/thrift/lib/cpp2/test/ProtocolBench.cpp     relative  time/iter   iters/s  serialized_size\n=============================================================================================\nObjectBinaryProtocol_write_BigListMixed                                    659.54us     1.52K              NaN\nObjectBinaryProtocol_read_BigListMixed                                       3.11ms    322.00           500009\nObjectBinaryProtocol_write_BigListMixedInt                                   1.27ms    790.12              NaN\nObjectBinaryProtocol_read_BigListMixedInt                                    6.70ms    149.29           850009\nObjectBinaryProtocol_write_LargeMapMixed                                   145.46ms      6.87              NaN\nObjectBinaryProtocol_read_LargeMapMixed                                    655.77ms      1.52         54000010\nObjectBinaryProtocol_write_ComplexStruct                                   160.19ms      6.24              NaN\nObjectBinaryProtocol_read_ComplexStruct                                    876.82ms      1.14         59006614\nObjectCompactProtocol_write_BigListMixed                                   799.68us     1.25K              NaN\nObjectCompactProtocol_read_BigListMixed                                      3.85ms    259.58           300005\nObjectCompactProtocol_write_BigListMixedInt                                  1.77ms    563.70              NaN\nObjectCompactProtocol_read_BigListMixedInt                                   7.27ms    137.47           720005\nObjectCompactProtocol_write_LargeMapMixed                                  150.58ms      6.64              NaN\nObjectCompactProtocol_read_LargeMapMixed                                   687.48ms      1.45         32991750\nObjectCompactProtocol_write_ComplexStruct                                  177.33ms      5.64              NaN\nObjectCompactProtocol_read_ComplexStruct                                   846.40ms      1.18         38637929\n=============================================================================================\n```\n```\n// after\n=============================================================================================\nfbcode/thrift/lib/cpp2/test/ProtocolBench.cpp     relative  time/iter   iters/s  serialized_size\n=============================================================================================\nObjectBinaryProtocol_write_BigListMixed                                    616.31us     1.62K              NaN\nObjectBinaryProtocol_read_BigListMixed                                       2.82ms    355.18           500009\nObjectBinaryProtocol_write_BigListMixedInt                                   1.35ms    738.65              NaN\nObjectBinaryProtocol_read_BigListMixedInt                                    7.88ms    126.87           850009\nObjectBinaryProtocol_write_LargeMapMixed                                   124.44ms      8.04              NaN\nObjectBinaryProtocol_read_LargeMapMixed                                    526.60ms      1.90         54000010\nObjectBinaryProtocol_write_ComplexStruct                                   128.39ms      7.79              NaN\nObjectBinaryProtocol_read_ComplexStruct                                    580.06ms      1.72         59006614\nObjectCompactProtocol_write_BigListMixed                                   743.84us     1.34K              NaN\nObjectCompactProtocol_read_BigListMixed                                      3.98ms    251.40           300005\nObjectCompactProtocol_write_BigListMixedInt                                  1.79ms    557.80              NaN\nObjectCompactProtocol_read_BigListMixedInt                                  10.49ms     95.34           720005\nObjectCompactProtocol_write_LargeMapMixed                                  126.08ms      7.93              NaN\nObjectCompactProtocol_read_LargeMapMixed                                   492.39ms      2.03         32991750\nObjectCompactProtocol_write_ComplexStruct                                  139.44ms      7.17              NaN\nObjectCompactProtocol_read_ComplexStruct                                   557.91ms      1.79         38637929\n=============================================================================================\n```\n\n// LargeMixed -> ~37% improvement in deserialization and ~29% regression in serialization\n```\n// before\n=============================================================================================\nfbcode/thrift/lib/cpp2/test/ProtocolBench.cpp     relative  time/iter   iters/s  serialized_size\n=============================================================================================\nObjectBinaryProtocol_write_LargeMixed                                        1.13us   888.40K              NaN\nObjectBinaryProtocol_read_LargeMixed                                         6.09us   164.27K              851\nObjectCompactProtocol_write_LargeMixed                                       1.50us   668.54K              NaN\nObjectCompactProtocol_read_LargeMixed                                        5.75us   174.04K              351\n=============================================================================================\n```\n```\n// after\n=============================================================================================\nfbcode/thrift/lib/cpp2/test/ProtocolBench.cpp     relative  time/iter   iters/s  serialized_size\n=============================================================================================\nObjectBinaryProtocol_write_LargeMixed                                        1.46us   682.76K              NaN\nObjectBinaryProtocol_read_LargeMixed                                         3.84us   260.13K              851\nObjectCompactProtocol_write_LargeMixed                                       1.81us   550.97K              NaN\nObjectCompactProtocol_read_LargeMixed                                        3.96us   252.25K              351\n=============================================================================================\n```\n\nReviewed By: Mizuchi\n\nDifferential Revision: D62352362\n\nfbshipit-source-id: d00cb613dba749bf9bc5f74bad58b408b1155ecc","shortMessageHtmlLink":"Use F14NodeMap for Protocol Object fields"}},{"before":"fc1123eec15e6d978e1219e5df29b03a4c92eecc","after":"cf5d97fa34545058a316eb7e50fafae5aca92709","ref":"refs/heads/main","pushedAt":"2024-09-09T22:41:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove duplicate extern\n\nSummary: Removed a duplicate extern.\n\nReviewed By: yoney\n\nDifferential Revision: D62399144\n\nfbshipit-source-id: 768bfc8aff174be0868d9ec32d6e807d2b45733a","shortMessageHtmlLink":"Remove duplicate extern"}},{"before":"1738d7a163329e1f8f54a09bdd0c703652ca0f48","after":"fc1123eec15e6d978e1219e5df29b03a4c92eecc","ref":"refs/heads/main","pushedAt":"2024-09-09T21:12:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"compare bug\n\nSummary:\nExample of problematic thrift:\n\n```\ncpp.Type{template = \"std::unordered_map\"}\ntypedef map<i64, i64> InnerMap\n\nstruct SomeStruct {\n  1: map<i32, InnerMap> m;\n}\n```\n\nReviewed By: thedavekwon\n\nDifferential Revision: D62379162\n\nfbshipit-source-id: 0b73eed54444ac956d5eb2c1c325ef0cd29df28a","shortMessageHtmlLink":"compare bug"}},{"before":"6082a52e4c474524bf5484ef4401a9f4e3352643","after":"1738d7a163329e1f8f54a09bdd0c703652ca0f48","ref":"refs/heads/main","pushedAt":"2024-09-09T21:06:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove C++20 features in DynamicPatch\n\nReviewed By: Mizuchi\n\nDifferential Revision: D62399250\n\nfbshipit-source-id: e2b002c19a72312b577ccd86abe49a46bdbbaec0","shortMessageHtmlLink":"Remove C++20 features in DynamicPatch"}},{"before":"0ca832715878046a46e549da25c4dd0dc6d8b20a","after":"6082a52e4c474524bf5484ef4401a9f4e3352643","ref":"refs/heads/main","pushedAt":"2024-09-09T19:57:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"reduce cython in converter\n\nSummary:\n1. Remove unused deps from TARGETS\n2. Only `cimport` types used as cython types. Having fewer cython deps means fewer potential weird xplat dependency issues.\n\nReviewed By: aristidisp\n\nDifferential Revision: D62326588\n\nfbshipit-source-id: a3fccc56cfaf1b9078291b51ff009ed00e01d8b4","shortMessageHtmlLink":"reduce cython in converter"}},{"before":"dac934795bd31669f839580c9d5dc5ff1b2a9469","after":"0ca832715878046a46e549da25c4dd0dc6d8b20a","ref":"refs/heads/main","pushedAt":"2024-09-09T19:52:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Address the linter warning\n\nSummary: Address linter warning\n\nReviewed By: thedavekwon\n\nDifferential Revision: D62357809\n\nfbshipit-source-id: 2b4225f4e976911daea193295085133110ae933b","shortMessageHtmlLink":"Address the linter warning"}},{"before":"a485c593d0e1abea36cc6d188dfab0cd97c007fc","after":"dac934795bd31669f839580c9d5dc5ff1b2a9469","ref":"refs/heads/main","pushedAt":"2024-09-09T19:39:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove co_yield std::move(i) from streaming test cases\n\nSummary: Remove `co_yield std::move(i)` from streaming test cases, as it generates lint error that variable is used after move.\n\nReviewed By: AkramaMirza\n\nDifferential Revision: D62323279\n\nfbshipit-source-id: cec2eff1bb854bd5845f1228e8ea64eb0cae8cf5","shortMessageHtmlLink":"Remove co_yield std::move(i) from streaming test cases"}},{"before":"258bb05cfa8ab6c47c4b06d8baff8746d229535d","after":"a485c593d0e1abea36cc6d188dfab0cd97c007fc","ref":"refs/heads/main","pushedAt":"2024-09-09T19:16:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable setting memory target for streaming queries in thrift\n\nSummary: Streaming clients in Python cannot set memory target because there is no api available in RpcOptions to set memory. This diff adds the change to support setting memory size on the streaming client.\n\nReviewed By: robertroeser, aristidisp\n\nDifferential Revision: D62321511\n\nfbshipit-source-id: bb8bb7bda4825052ffb25a9694b4537ec9c2500c","shortMessageHtmlLink":"Enable setting memory target for streaming queries in thrift"}},{"before":"92a9743e721f2185d81cc5916026988deaa37bad","after":"258bb05cfa8ab6c47c4b06d8baff8746d229535d","ref":"refs/heads/main","pushedAt":"2024-09-09T19:12:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix formatting of WHISKER_KEYWORDS()\n\nSummary: clang-format is confused because `not` is a unary operator in C++.\n\nReviewed By: vitaut\n\nDifferential Revision: D62269780\n\nfbshipit-source-id: bf17d67a92754899d9631ad246a78a0af61ca25c","shortMessageHtmlLink":"Fix formatting of WHISKER_KEYWORDS()"}},{"before":"16a919a471c169250b600a4f1bf3e128384e87f0","after":"92a9743e721f2185d81cc5916026988deaa37bad","ref":"refs/heads/main","pushedAt":"2024-09-09T19:06:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rename processorMap to processorFunctionMap\n\nSummary:\nThe word \"processor\" is extremely overloaded. Hard to read code.\n\nRename field that stores `map[string]thrift.ProcessorFunction` from `processorMap` to `processorFunctionMap`.\n\nSo that things are clear.\n\nReviewed By: awalterschulze\n\nDifferential Revision: D62307222\n\nfbshipit-source-id: 6d3c35ed12aa89eed5c78dd5963f3c202f968382","shortMessageHtmlLink":"Rename processorMap to processorFunctionMap"}},{"before":"9eb5ff40b43c9fc16aac3843a192ae6b69dd0a51","after":"16a919a471c169250b600a4f1bf3e128384e87f0","ref":"refs/heads/main","pushedAt":"2024-09-09T18:57:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move assign patch out of ValuePatch\n\nSummary:\nCurrently\n\n* AssignPatch depends on old dynamic patch (protocol::Object),\n* But the new DynamicPatch depends on ValuePatch (which includes AssignPatch).\n\nIf we want to replace the old dynamic patch with new Dynamic patch, this creates circular dependencies.\n\nThis diff moved AssignPatch to a separate header.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D62260303\n\nfbshipit-source-id: a45a6362526ff2da668f66505ac2762c14fdf4dd","shortMessageHtmlLink":"Move assign patch out of ValuePatch"}},{"before":"953330e8cec46293c6a5525a8c718352f3d68880","after":"9eb5ff40b43c9fc16aac3843a192ae6b69dd0a51","ref":"refs/heads/main","pushedAt":"2024-09-09T18:49:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Implement missing __repr__ for mutable types\n\nSummary:\nAdd missing `__repr__` for `MutableStruct` and `MutableMap`.\nAdd test to compare mutable and immutable struct repr.\n\nDifferential Revision: D62357277\n\nfbshipit-source-id: d8c82c81e8e61a9ca2fa5616e1e34a40662ace64","shortMessageHtmlLink":"Implement missing __repr__ for mutable types"}},{"before":"279c91a6499940df9998f100393348c894e6641e","after":"953330e8cec46293c6a5525a8c718352f3d68880","ref":"refs/heads/main","pushedAt":"2024-09-09T18:44:54.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix dependencies in thrift/lib/python:util\n\nSummary: Some of these `folly/python` targets aren't set up properly in BUCK but we shouldn't be depending on them anyways.\n\nReviewed By: yoney\n\nDifferential Revision: D62330079\n\nfbshipit-source-id: 65b166f304ce0b6b950a7a5f096803e4cc95c797","shortMessageHtmlLink":"fix dependencies in thrift/lib/python:util"}},{"before":"dd5080ac2e7eaddd0b5acf90ce9080d3f124f3b3","after":"279c91a6499940df9998f100393348c894e6641e","ref":"refs/heads/main","pushedAt":"2024-09-09T16:56:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update MutableUnion current field attributes\n\nSummary: Update the current field value attributes after creating an instance\n\nDifferential Revision: D62356484\n\nfbshipit-source-id: bf9d3d7a5be9de5a8c2db39e8d01a8c72b62bc18","shortMessageHtmlLink":"Update MutableUnion current field attributes"}},{"before":"19bbdb586e0f1ee20556ee2e8a25643e0f4303a9","after":"dd5080ac2e7eaddd0b5acf90ce9080d3f124f3b3","ref":"refs/heads/main","pushedAt":"2024-09-09T16:39:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/e5227023f002cd2c2d3f3ede03a36c496b145672\nhttps://github.com/facebook/fb303/commit/682d826cd2416497f3da75e3b7fdd30ab545ad9c\nhttps://github.com/facebook/fbthrift/commit/2af7c9b50f0473be232f57ec43a3af0b5fab8a68\nhttps://github.com/facebook/mvfst/commit/eba2ba9efcf7dd49e0a86145a8ec5fdf8e1b0379\nhttps://github.com/facebook/proxygen/commit/ed7fc292df3d21501d9f7792721313ea39a0dd76\nhttps://github.com/facebook/wangle/commit/97997d1dbfd2154631d04f0fe3759d2e15638576\nhttps://github.com/facebookexperimental/rust-shed/commit/31de5124018f2d3e48e32e6a60ed12813a9715b4\n\nReviewed By: ajb85\n\nfbshipit-source-id: cd36e31c8446bcab7cb18d50a23645351d1ca98d","shortMessageHtmlLink":"Updating submodules"}},{"before":"814ff87f73f919031dce402dbe2e1cbd8264adea","after":"19bbdb586e0f1ee20556ee2e8a25643e0f4303a9","ref":"refs/heads/main","pushedAt":"2024-09-09T16:35:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add documentation for AnyPatch\n\nSummary: add documentation for AnyPatch. Will re-visit to add some changelog and api docs separately.\n\nReviewed By: avalonalex, kaczmarekmhl\n\nDifferential Revision: D62251326\n\nfbshipit-source-id: fae25f31501f310419e37716a4d6040af2e5b47e","shortMessageHtmlLink":"Add documentation for AnyPatch"}},{"before":"2af7c9b50f0473be232f57ec43a3af0b5fab8a68","after":"814ff87f73f919031dce402dbe2e1cbd8264adea","ref":"refs/heads/main","pushedAt":"2024-09-09T16:12:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Consolidated naming for test structs\n\nSummary: Renaming several test structs to include a postfix that indicates their mutability status, aligning them with the rest of the test structs that follow this naming convention.\n\nDifferential Revision: D62357114\n\nfbshipit-source-id: 39ce55421554b1786403e4d05093aa8088e0d4de","shortMessageHtmlLink":"Consolidated naming for test structs"}},{"before":"b31299af9a1630280888132be342bca6f6622158","after":"2af7c9b50f0473be232f57ec43a3af0b5fab8a68","ref":"refs/heads/main","pushedAt":"2024-09-09T15:18:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add types_impl.py\n\nSummary:\nThis diff bootstraps the empty `types_impl.py` file. This diff splits out the following changes from diff to make thrift-py3 enums into python, not cython.\n- t_mstch_py3_generator.cc changes\n- python3.bzl changes\n- types_impl.py template (enum generation is added on top)\n\nReviewed By: yoney\n\nDifferential Revision: D62312546\n\nfbshipit-source-id: b1048901caa72c52bd08b71b204ff0e1bc1f13a3","shortMessageHtmlLink":"add types_impl.py"}},{"before":"970063a6552fa9f4bd4e76f5a41165b69da8cc4c","after":"b31299af9a1630280888132be342bca6f6622158","ref":"refs/heads/main","pushedAt":"2024-09-09T14:24:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-land optimizing converting Thrift values to Python with fixes\n\nSummary:\nTrying again to reland D62076661, with the underlying bug fixed\n\nig-fbcode-test\n\nReviewed By: anik-dasgupta\n\nDifferential Revision: D62248473\n\nfbshipit-source-id: 211fb6b84eee9fb758d4830dbb1abdcfc10c3277","shortMessageHtmlLink":"Re-land optimizing converting Thrift values to Python with fixes"}},{"before":"f8f97d50c3527176ccc1c86873369a3992678287","after":"970063a6552fa9f4bd4e76f5a41165b69da8cc4c","ref":"refs/heads/main","pushedAt":"2024-09-08T17:10:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"5/[thrift][be]add QpsOverloadChecker\n\nSummary: Moves qps over check logic into an overload checker interface\n\nReviewed By: praihan\n\nDifferential Revision: D61928721\n\nfbshipit-source-id: 4f45c6ceb06407755141f0a79e3d965520513ce1","shortMessageHtmlLink":"5/[thrift][be]add QpsOverloadChecker"}},{"before":"9ccdb9673696d158806ff87be8594a05be6180df","after":"f8f97d50c3527176ccc1c86873369a3992678287","ref":"refs/heads/main","pushedAt":"2024-09-08T16:33:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/fb303/commit/86a5916f3adb9e55ab906bd28abc606467b37924\nhttps://github.com/facebook/fbthrift/commit/9ccdb9673696d158806ff87be8594a05be6180df\nhttps://github.com/facebook/mvfst/commit/d929a1cd48241c08be0fc25be4da14fee931ee37\nhttps://github.com/facebook/proxygen/commit/e583e4f7e4e45a5c7ebfbded62433aadede21f73\nhttps://github.com/facebook/wangle/commit/aace5ca19743008d0efcabc750ad440b20c4f43e\nhttps://github.com/facebookexperimental/edencommon/commit/bc39a9333d29b6d2886d13618d5c34f3d4f80337\nhttps://github.com/facebookexperimental/rust-shed/commit/95b3bc205aa666d1b45f6b65087122628ecc9fdd\nhttps://github.com/facebookincubator/fizz/commit/f8746348b2ed0d0864f4b5386eb7e86324fbe41e\n\nReviewed By: ajb85\n\nfbshipit-source-id: 40ec712f7543b5212975c4c81e5b3bf6a02e51cd","shortMessageHtmlLink":"Updating submodules"}},{"before":"da6c2b846a56363d72cd3e80a87ab5e02adfb3f5","after":"9ccdb9673696d158806ff87be8594a05be6180df","ref":"refs/heads/main","pushedAt":"2024-09-07T21:48:12.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Switch AnyPatch::patchPrior and patchAfter from \"map<Type, list<AnyStruct>>\" to \"map<Type, AnyStruct>\"\n\nSummary: We have implemented dynamic patch merging so we don't need a list of AnyStruct anymore.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D62251011\n\nfbshipit-source-id: fb038f2f89aaf34f1aab9feafaf422ead04ca0df","shortMessageHtmlLink":"Switch AnyPatch::patchPrior and patchAfter from \"map&lt;Type, list&lt;AnySt…"}},{"before":"75edbdb339f0bc77115278dc30e1c6e063b965dd","after":"da6c2b846a56363d72cd3e80a87ab5e02adfb3f5","ref":"refs/heads/main","pushedAt":"2024-09-07T18:05:37.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move some implementation from AnyPatch.h to AnyPatch.cpp\n\nSummary: This diff just copy-paste without making any changes. All linter errors are pre-existing.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D62245913\n\nfbshipit-source-id: e28f6c1d01c1a36097eb0dba115e9dbcbee7894b","shortMessageHtmlLink":"Move some implementation from AnyPatch.h to AnyPatch.cpp"}},{"before":"8a3ea758f41b4591f44c9649d2b51b150d4fa275","after":"75edbdb339f0bc77115278dc30e1c6e063b965dd","ref":"refs/heads/main","pushedAt":"2024-09-07T16:33:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/fb303/commit/f6787adc83ee73ee909906b7659200f3ddca0c77\nhttps://github.com/facebook/fbthrift/commit/8a3ea758f41b4591f44c9649d2b51b150d4fa275\nhttps://github.com/facebook/folly/commit/2fb0ca3c553c803a8c9bf6b7b4bc98f1b0a79d4e\nhttps://github.com/facebook/mvfst/commit/13156b96ec512fd9cd56c280253794b8ebdf46a3\nhttps://github.com/facebook/proxygen/commit/21064c0477e198906cec2fcebec5686183be2eba\nhttps://github.com/facebook/wangle/commit/1260d25d552801133f2eb2ced2df09c7f7ae1f66\nhttps://github.com/facebookexperimental/edencommon/commit/363052d7bb66a466124f3141e092e97985063e3b\nhttps://github.com/facebookexperimental/rust-shed/commit/3d9fbd6d3d3b8a6790662ad402969b88ddf45595\nhttps://github.com/facebookincubator/fizz/commit/bcecb0db99632bd71912f8cebfa49924a83cd695\n\nReviewed By: ajb85\n\nfbshipit-source-id: 243e8ae8ea0fe89814228668e3b162302098614b","shortMessageHtmlLink":"Updating submodules"}},{"before":"e3875b80bd51165d263f77746e6b34ce8eb5cafe","after":"8a3ea758f41b4591f44c9649d2b51b150d4fa275","ref":"refs/heads/main","pushedAt":"2024-09-07T05:22:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"handle invalid metadata payload correctly\n\nSummary:\nAfter deserialize metadata, cursor location should match `frame.payload().metadataSize())` rather than just not greater than it.\n\nCurrent logic may allow invalid setup frame to go through.\n\nReviewed By: tlj77\n\nDifferential Revision: D62332462\n\nfbshipit-source-id: 2829f1e08f7167d438f2d9b06977e05d26406e6a","shortMessageHtmlLink":"handle invalid metadata payload correctly"}},{"before":"5870e0a7ea5320b1019c576dd2a9d8aad5d2cb1a","after":"e3875b80bd51165d263f77746e6b34ce8eb5cafe","ref":"refs/heads/main","pushedAt":"2024-09-06T23:37:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Parameterise the union test for mutable types\n\nSummary:\nParameterize the union test for mutable types. The changes are relatively more significant than other parameterized changes because of the interface change between immutable and mutable unions.\n\n- `Union.type` vs `MutableUnion.fbthrift_current_field`\n- `Union.value` vs `MutableUnion.fbthrift_current_value`\n- `Union.Type` vs `MutableUnion.FbThriftUnionFieldEnum`\n- `Union.Type.EMPTY` vs `MutableUnion.FbThriftUnionFieldEnum.FBTHRIFT_UNION_EMPTY`\\\n\nA few small missing `MutableUnion` methods have been implemented to pass the tests.\n\nReviewed By: ahilger\n\nDifferential Revision: D62237228\n\nfbshipit-source-id: 7c5a3b6f0bc0f2559157060968e2dd6445e2f391","shortMessageHtmlLink":"Parameterise the union test for mutable types"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEsYZR4AA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fbthrift"}