From fbf1e9ff073830fec7dfdf99ec19f388db8e36ce Mon Sep 17 00:00:00 2001 From: GLVS Kiriti Date: Mon, 17 Jun 2024 21:38:49 +0530 Subject: [PATCH] feat(declarative): add detailed error handling and logging Signed-off-by: GLVS Kiriti --- cmd/common.go | 4 ++-- cmd/declarative.go | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cmd/common.go b/cmd/common.go index cc7d0f5..abd61e2 100644 --- a/cmd/common.go +++ b/cmd/common.go @@ -30,12 +30,12 @@ import ( func parseYamlFile(filepath string) (declarative.Tests, error) { data, err := os.ReadFile(filepath) if err != nil { - return declarative.Tests{}, err + return declarative.Tests{}, fmt.Errorf("an error occurred while parsing file %s: %w", filepath, err) } var tests declarative.Tests err = yaml.Unmarshal(data, &tests) if err != nil { - return declarative.Tests{}, err + return declarative.Tests{}, fmt.Errorf("an error occurred while unmarshalling yaml data: %w", err) } return tests, nil } diff --git a/cmd/declarative.go b/cmd/declarative.go index c1a5306..1bced7f 100644 --- a/cmd/declarative.go +++ b/cmd/declarative.go @@ -52,7 +52,10 @@ func NewDeclarative() *cobra.Command { // Print all errors if len(failedTests) > 0 { - return fmt.Errorf("some tests failed %v", failedTests) + for _, ft := range failedTests { + fmt.Println(ft) + } + return fmt.Errorf("some tests failed, see previous logs") } return nil