Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet connection error when clicking Version from help menu #34

Open
tyler-dane opened this issue Aug 5, 2021 · 4 comments
Open

Comments

@tyler-dane
Copy link
Member

Describe the bug
Long loading spinner followed by Please check internet connection! message

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings > Help
  2. Click on Version
  3. See Loading spinner for a while
  4. See Please check internet connection! toast message

Expected behavior
I'm not sure what this is supposed to do.
It's confusing from an end user perspective

Environment (please complete the following information):

  • Pixel 10

Additional context
Does the row version have to be a clickable item? What is going on behind the scenes during that Loading message?

@tyler-dane tyler-dane added the bug Something isn't working label Aug 5, 2021
@bhanup212
Copy link

on click of version, we calling API to check whether new app version is available or not

@tyler-dane
Copy link
Member Author

Gotcha, thank you.

I think it's fine to leave it as-is until after the initial release. Since it doesn't have any destructive or crashing behavior, it'll just confuse a few curious users, which is OK for now.

Since we have all the basics we need for an initial release, I think it'd make more sense to prioritize the infrastructure improvements we chatted about in GitHub and here.

@tyler-dane tyler-dane removed the bug Something isn't working label Aug 6, 2021
@bhanup212
Copy link

@tyler-hitzeman can you suggest what needs to done here for app update?

@tyler-dane
Copy link
Member Author

tyler-dane commented Aug 30, 2021

My understanding is that the feature is meant to allow users to ensure they have the most up-to-date version. But since users can get app updates and version info from the Play Store, I don't see any value in keeping this functionality in Focus Launcher's menu; it only complications the settings menu. Unless I'm missing something, I'd recommend simply removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants