Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DNSRecord cloudconfiguration #863

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix DNSRecord cloudconfiguration #863

merged 1 commit into from
May 21, 2024

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind regression
/platform azure

What this PR does / why we need it:
This PR fixes the nil-pointer error when no cloudprofile config is found. In addition, the cloudconfiguration will now be read from the DNSRecordConfig instead. The DNSRecord is not really tied to the cloudprofile of the shoot. It is rather the seed configuration that matters, hence the configuration will now be read from the providerConfig of the object directly.

/invite @AndreasBurger

Which issue(s) this PR fixes:
Fixes #859

Special notes for your reviewer:

Release note:

Introduce `DNSRecordConfig` object to configure the cloud environment for the DNSRecord object.

@kon-angelo kon-angelo requested review from a team as code owners May 19, 2024 11:06
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else labels May 19, 2024
@gardener-robot gardener-robot added area/control-plane Control plane related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 19, 2024
AndreasBurger
AndreasBurger approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lgtm

@kon-angelo kon-angelo merged commit 2aa0d4f into gardener:master May 21, 2024
17 checks passed
@kon-angelo kon-angelo deleted the fix/dnsrecord-nil branch May 21, 2024 11:04
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 21, 2024
@kon-angelo kon-angelo mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/api-change API change with impact on API users kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use azure dns provider with non-azure infrastructure provider
5 participants
@kon-angelo @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot