fix(core): don't override alwaysShowVerticalScroll flag #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537)) - requires core lib [PR #537](6pac/SlickGrid#537) to be merged and released
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 149 149
Lines 9946 9945 -1
Branches 3516 3515 -1
=========================================
- Hits 9946 9945 -1
Continue to review full report at Codecov.
|
ghiscoding
changed the title
ghiscoding
deleted the
bugfix/frozen-dont-override-show-vertical-scroll
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alwaysShowVerticalScrollflag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when thealwaysShowVerticalScrollis set to True (see core lib PR #537)