refactor(editors): serialize select editors to actual type

not sure why i thought I should always make the serialized value a string. Probabaly because I was chaning the `dateEditor` at the same time. Anyway, the serailied value from the `valueName` property should always be a simple type.
ghiscoding · May 16, 2018 · 016f070 · 016f070
1 parent 2ee03b0
commit 016f070
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/aurelia-slickgrid/src/aurelia-slickgrid/editors/multipleSelectEditor.ts b/aurelia-slickgrid/src/aurelia-slickgrid/editors/multipleSelectEditor.ts
@@ -118,9 +118,7 @@ export class MultipleSelectEditor implements Editor {
   }
 
   applyValue(item: any, state: any): void {
-     item[this.args.column.field] = this.collection
-      .filter(c => state.indexOf(c[this.valueName].toString()) !== -1)
-      .map(c => c[this.valueName]);
+    item[this.args.column.field] = state;
   }
 
   destroy() {
@@ -143,7 +141,7 @@ export class MultipleSelectEditor implements Editor {
   }
 
   serializeValue(): any {
-    return this.$editorElm.val();
+    return this.currentValues;
   }
 
   focus() {

diff --git a/aurelia-slickgrid/src/aurelia-slickgrid/editors/singleSelectEditor.ts b/aurelia-slickgrid/src/aurelia-slickgrid/editors/singleSelectEditor.ts
@@ -110,8 +110,7 @@ export class SingleSelectEditor implements Editor {
   }
 
   applyValue(item: any, state: any): void {
-    item[this.args.column.field] = findOrDefault(this.collection, (c: any) =>
-      c[this.valueName].toString() === state)[this.valueName];
+    item[this.args.column.field] = state;
   }
 
   destroy() {
@@ -135,7 +134,7 @@ export class SingleSelectEditor implements Editor {
   }
 
   serializeValue(): any {
-    return this.$editorElm.val();
+    return this.currentValue;
   }
 
   focus() {