Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): fix serialization/deserilization in editors #58

Merged
merged 3 commits into from
May 18, 2018

Commits on May 16, 2018

  1. fix(editors): fix serialization/deserilization in editors

    dateEditor was serializing/deserializing wrong value. Also need to check for empty date value because moment will throw an error. `singleSelect` and `multipleSelectEditor` were serializing the actual value (e.g number type) when it should be serializing to a string and `applyValue` should be deserializing from string to actual type (e.g. number).
    
    closes #56
    jmzagorski committed May 16, 2018
    Configuration menu
    Copy the full SHA
    2ee03b0 View commit details
    Browse the repository at this point in the history
  2. refactor(editors): serialize select editors to actual type

    not sure why i thought I should always make the serialized value a string. Probabaly because I was chaning the `dateEditor` at the same time. Anyway, the serailied value from the `valueName` property should always be a simple type.
    jmzagorski committed May 16, 2018
    Configuration menu
    Copy the full SHA
    016f070 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. refactor(editors): load defaultDate into flatpickr on loadValue

    this will allow the excel cell copy to work when serializing this.$input.value()
    jmzagorski committed May 17, 2018
    Configuration menu
    Copy the full SHA
    7bc8baf View commit details
    Browse the repository at this point in the history