-
-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(filters): new
filterPredicate
shouldn't break other column filt…
…ers (#1531) * fix(filters): new `filterPredicate` shouldn't break other column filters - the previous PR to implement `filterPredicate` that was not caught originally which had the indirect effect of breaking the other filter columns, the issue was caused by the fact that calling a `return` within the `for` loop of all filters was cancelling the next filters because a `return` breaks the loop. - So the fix is to only call `return` when the `filterPredicate` returns `false` which mean that at point the row data context is officially filtered out, so not inspecting further filters make sense * fix(demo): improve SQL LIKE with filter of `Ta%30%` - `Ta%30%` wasn't working correctly before, it should be equivalent to: StartsWith "Ta" and Contains "30" anywhere
- Loading branch information
1 parent
828eb8a
commit 27777ef
Showing
3 changed files
with
45 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters