Skip to content

Commit

Permalink
fix(Grouping): Draggable Grouping cols reorder missing `impactedColum…
Browse files Browse the repository at this point in the history
…ns` (#1557)

* fix(Grouping): Draggable Grouping cols reorder missing impactedColumns
  • Loading branch information
ghiscoding committed Jun 5, 2024
1 parent 9e2dd65 commit 69125c2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ describe('Draggable Grouping Plugin', () => {

expect(setColumnsSpy).toHaveBeenCalledWith([mockColumns[2], mockColumns[2]]);
expect(setColumnResizeSpy).toHaveBeenCalled();
expect(triggerSpy).toHaveBeenCalledWith(gridStub.onColumnsReordered, { grid: gridStub });
expect(triggerSpy).toHaveBeenCalledWith(gridStub.onColumnsReordered, { grid: gridStub, impactedColumns: expect.arrayContaining([mockColumns[2]]) });
});

it('should drag over dropzone and expect hover css class be added and removed when dragging outside of dropzone', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/extensions/slickDraggableGrouping.ts
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ export class SlickDraggableGrouping {
finalReorderedColumns.push(reorderedColumns[getColumnIndex.call(grid, reorderedId)]);
}
setColumns.call(grid, finalReorderedColumns);
trigger.call(grid, grid.onColumnsReordered, { grid });
trigger.call(grid, grid.onColumnsReordered, { grid, impactedColumns: finalReorderedColumns });
e.stopPropagation();
setupColumnResize.call(grid);
}
Expand Down

0 comments on commit 69125c2

Please sign in to comment.