Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling): add frozen on all possible elements with SASS variables #138

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 5, 2020

  • add frozen to both the pre-header & header columns

  • add SASS variables to customize border on these 3 properties (pre-header, header, header-row aka filter row)

  • fix(core): don't override alwaysShowVerticalScroll flag

    • the alwaysShowVerticalScroll flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the alwaysShowVerticalScroll is set to True (see core lib PR #537)

Ghislain Beaulac added 2 commits October 5, 2020 14:21
- add frozen to both the pre-header & header columns
- add SASS variables to customize border on these 3 properties (pre-header, header, header-row aka filter row)
- the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537))
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0086402). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #138   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       196           
  Lines             ?     11256           
  Branches          ?      3691           
==========================================
  Hits              ?     11256           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0086402...847f944. Read the comment docs.

@ghiscoding ghiscoding merged commit c61da91 into master Oct 7, 2020
@ghiscoding ghiscoding deleted the feat/frozen-styling branch October 7, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant