chore: remove exports.node from all packages
#1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I don't think we need the `exports.node` since it's not a package meant to be used in NodeJS but rather in a browser, so let's remove it - also move `module` to be after the `exports` since order might matter (not entirely sure but that is what `rimraf` does and it's a package made a NodeJS member, so it should be a good indication) - related to issue #1601
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1603 +/- ##
=======================================
Coverage 99.8% 99.8%
=======================================
Files 198 198
Lines 21793 21793
Branches 7159 7020 -139
=======================================
Hits 21732 21732
- Misses 55 61 +6
+ Partials 6 0 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports.nodesince it's not a package meant to be used in NodeJS but rather in a browser, so let's remove itmoduleto be after theexportssince order might matter (not entirely sure but that is whatrimrafdoes and it's a package made a NodeJS member, so it should be a good indication)