feat: add columnPickerLabel for custom label, also fix #1605
#1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes #1605 by reverting #1476 - this PR fixes #1605 without regressing on older issue #1475 - also add a `columnPickerLabel` option in the Column interface, because in some cases the default header column extractor (defined in the global grid options) will return all text it finds (via `.textContent`) and that might not be ideal given that an HTML element with extra button will also extract and append the button text in both ColumnPicker/GridMenu
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1607 +/- ##
=======================================
Coverage 99.8% 99.8%
=======================================
Files 198 198
Lines 21795 21795
Branches 7303 7021 -282
=======================================
Hits 21734 21734
Misses 61 61 ☔ View full report in Codecov by Sentry. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1605
columnPickerLabeloption in the Column interface, because in some cases the default header column extractor (defined in the global grid options) will return all text it finds (via.textContentas mentioned in this comment) and that might not be ideal given that an HTML element with extra button will also extract and append the button text in both ColumnPicker/GridMenuTODOs