Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tooltips on icon formatters #1608

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

zewa666
Copy link
Contributor

@zewa666 zewa666 commented Jul 17, 2024

adds the possibility to define tooltips via the title tag on icon formatters

Copy link

stackblitz bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zewa666
Copy link
Contributor Author

zewa666 commented Jul 17, 2024

this is just a minor feature but something I stumbled on the other day when working on a new feature.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (e34971d) to head (317affd).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1608     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         198     198             
  Lines       21795   21796      +1     
  Branches     7302    7303      +1     
========================================
+ Hits        21734   21735      +1     
+ Misses         61      55      -6     
- Partials        0       6      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding
Copy link
Owner

makes sense, thanks for that

out of topic, I'm hearing and reading about Supabase more now (probably because it's now in GA after 4 years of Beta) and was wondering, are you using it with OData and SlickGrid or some other ways? Just curious, might want to finally look at doing a personal project now that I'm pretty much done with SlickGrid work (though I'm working on a new feature coming soon that will probably interest you, stay tuned, maybe a POC later tonight)

@zewa666
Copy link
Contributor Author

zewa666 commented Jul 17, 2024

Supabase is quite interesting though I'd personally prefer Hasura. Have been using it with super great success for a larger project and would prefer that everytime again. The thing is, once persistance and handling CRUD becomes a free thing along with permissions etc, all handled by fundamental DB principles, nothing beats the productivity boost. Plus, I guess the GraphQL layer should nicely integrate with Slickgrid, though I have to admit I haven't yet tried so.

@ghiscoding
Copy link
Owner

ghiscoding commented Jul 17, 2024

ah yeah you mentioned it last time when we did the Header Menu thing. I think I'd also personally prefer GraphQL over OData, so Hasura make sense in this case. Thanks for the info, the web world is evolving so fast, it's hard to keep up 😅

@ghiscoding ghiscoding merged commit bd52e00 into ghiscoding:master Jul 17, 2024
6 checks passed
@ghiscoding
Copy link
Owner

ghiscoding commented Jul 17, 2024

@zewa666
I think that the biggest challenge with Hasura would be to create the structure that I defined for the Pagination/Sorting/Filtering. I assume that's all doable in Hasura and perhaps we could create a new package in universal to support Hasura following this structure that I require. I'm just guessing here since I haven't tried anything and barely read their docs... or you could use GraphQL to fetch all dataset just once but if the dataset is large then that won't cut it

Looking more at the docs, it seems to be quite different compare to my approach, so I guess we would a customize port of the GraphQL Service that I made

Do you know if they have an online GraphQL DB that we can hook to? So that it could be used for possibly creating and/or testing SlickGrid with it in a demo example.

interesting video : How to add GraphQL to Supabase with Hasura

@zewa666
Copy link
Contributor Author

zewa666 commented Jul 17, 2024

havent yet looked into slickgrids graphql backend but I guess it should be doable to adjust things to match Hasuras style.

the biggest pro with Hasura where it live-queries, aka graphql subscriptions but with server push on change. that alone is so very cool it could be worth the hassle (think of your realtime example)

Hasura cloud offers a free tier. as for db go for something like https://neon.tech/pricing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants