Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): strip hidden special chars on context menu Copy command #537

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 8, 2021

  • there were some hidden characters that were carried over when doing copy+paste, and the only way I found to fix that was to replace \u034f (unicode char) with empty string
  • we should also trim the string to remove any empty spaces from start/end of string

N6guh25Jni

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #537 (221c05d) into master (fe92320) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          221       221           
  Lines        14074     14075    +1     
  Branches      4804      4805    +1     
=========================================
+ Hits         14074     14075    +1     
Impacted Files Coverage Δ
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
...ckages/common/src/formatters/formatterUtilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe92320...221c05d. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit f6c03ee into master Nov 9, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/context-menu-copy-strip-hidden-chars branch November 9, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants