From e3a86ed8b658d657dd6a3c8e0ef2e58460decfda Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Thu, 22 Feb 2024 17:53:21 +0000 Subject: [PATCH] Add comment justifying why we set `cache: false` --- .github/workflows/__go-tracing-autobuilder.yml | 2 ++ .github/workflows/__go-tracing-custom-build-steps.yml | 2 ++ .github/workflows/__go-tracing-legacy-workflow.yml | 2 ++ pr-checks/checks/go-tracing-autobuilder.yml | 2 ++ pr-checks/checks/go-tracing-custom-build-steps.yml | 2 ++ pr-checks/checks/go-tracing-legacy-workflow.yml | 2 ++ 6 files changed, 12 insertions(+) diff --git a/.github/workflows/__go-tracing-autobuilder.yml b/.github/workflows/__go-tracing-autobuilder.yml index 28ff186733..5f1c28df3d 100644 --- a/.github/workflows/__go-tracing-autobuilder.yml +++ b/.github/workflows/__go-tracing-autobuilder.yml @@ -89,6 +89,8 @@ jobs: - uses: actions/setup-go@v5 with: go-version: ~1.22.0 + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/.github/workflows/__go-tracing-custom-build-steps.yml b/.github/workflows/__go-tracing-custom-build-steps.yml index 5fa7524130..7d55eaa069 100644 --- a/.github/workflows/__go-tracing-custom-build-steps.yml +++ b/.github/workflows/__go-tracing-custom-build-steps.yml @@ -89,6 +89,8 @@ jobs: - uses: actions/setup-go@v5 with: go-version: ~1.22.0 + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/.github/workflows/__go-tracing-legacy-workflow.yml b/.github/workflows/__go-tracing-legacy-workflow.yml index 65bb400564..a1e9bb5cee 100644 --- a/.github/workflows/__go-tracing-legacy-workflow.yml +++ b/.github/workflows/__go-tracing-legacy-workflow.yml @@ -89,6 +89,8 @@ jobs: - uses: actions/setup-go@v5 with: go-version: ~1.22.0 + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/pr-checks/checks/go-tracing-autobuilder.yml b/pr-checks/checks/go-tracing-autobuilder.yml index 1ccfb1ecea..f5e5a963d6 100644 --- a/pr-checks/checks/go-tracing-autobuilder.yml +++ b/pr-checks/checks/go-tracing-autobuilder.yml @@ -7,6 +7,8 @@ steps: - uses: actions/setup-go@v5 with: go-version: "~1.22.0" + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/pr-checks/checks/go-tracing-custom-build-steps.yml b/pr-checks/checks/go-tracing-custom-build-steps.yml index acdef07a40..da0939f19b 100644 --- a/pr-checks/checks/go-tracing-custom-build-steps.yml +++ b/pr-checks/checks/go-tracing-custom-build-steps.yml @@ -5,6 +5,8 @@ steps: - uses: actions/setup-go@v5 with: go-version: "~1.22.0" + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/pr-checks/checks/go-tracing-legacy-workflow.yml b/pr-checks/checks/go-tracing-legacy-workflow.yml index 40400bc468..203d779462 100644 --- a/pr-checks/checks/go-tracing-legacy-workflow.yml +++ b/pr-checks/checks/go-tracing-legacy-workflow.yml @@ -7,6 +7,8 @@ steps: - uses: actions/setup-go@v5 with: go-version: "~1.22.0" + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: