{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23096959,"defaultBranch":"master","name":"go","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-19T04:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719946337.0","currentOid":""},"activityList":{"items":[{"before":"82c14346d89ec0eeca114f9ca0e88516b2cda454","after":"ad77cefeb2f5b3f1cef4383e974195ffc8610236","ref":"refs/heads/master","pushedAt":"2024-07-05T10:46:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: correct RewriteMultiValueCall fatal message\n\nThe function name was changed in CL 331470.\n\nChange-Id: I6f41866a9c5ccce594dd84185ebfc1c5af280184\nReviewed-on: https://go-review.googlesource.com/c/go/+/596395\nReviewed-by: Cherry Mui \nAuto-Submit: Cuong Manh Le \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: correct RewriteMultiValueCall fatal message"}},{"before":"7d19d508a994be9731e27b14b6ecc13ccf527138","after":"82c14346d89ec0eeca114f9ca0e88516b2cda454","ref":"refs/heads/master","pushedAt":"2024-07-03T22:43:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: don't disable memory profiling when pprof.WriteHeapProfile is used\n\nWe have an optimization that if the memory profile is not consumed\nanywhere, we set the memory profiling rate to 0 to disable the\n\"background\" low-rate profiling. We detect whether the memory\nprofile is used by checking whether the runtime.MemProfile function\nis reachable at link time. Previously, all APIs that access the\nmemory profile go through runtime.MemProfile. But the code was\nrefactored in CL 572396, and now the legacy entry point\nWriteHeapProfile uses pprof_memProfileInternal without going\nthrough runtime.MemProfile. In fact, even with the recommended\nruntime/pprof.Profile API (pprof.Lookup or pprof.Profiles),\nruntime.MemProfile is only (happen to be) reachable through\ncountHeap.\n\nChange the linker to check runtime.memProfileInternal instead,\nwhich is on all code paths that retrieve the memory profile. Add\na test case for WriteHeapProfile, so we cover all entry points.\n\nFixes #68136.\n\nChange-Id: I075c8d45c95c81825a1822f032e23107aea4303c\nReviewed-on: https://go-review.googlesource.com/c/go/+/596538\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link: don't disable memory profiling when pprof.WriteHeapProfile …"}},{"before":"5f50b1e3bf710b4107eb38496d932b3d9bd1fc98","after":"7d19d508a994be9731e27b14b6ecc13ccf527138","ref":"refs/heads/master","pushedAt":"2024-07-03T19:03:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/cgo: read CGO_LDFLAGS environment variable\n\nFor #66456 we changed from the CGO_LDFLAGS environment variable to\nthe -ldflags option. This broke Bazel, which uses CGO_LDFLAGS.\nSo restore reading CGO_LDFLAGS for now.\n\nFor #66456\n\nChange-Id: Iebdd8bde1c7c18da09c6370e284c7ac7fa08fc54\nReviewed-on: https://go-review.googlesource.com/c/go/+/596615\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"cmd/cgo: read CGO_LDFLAGS environment variable"}},{"before":"71f9dbb1e409a28680f40c60fad5a386ed92a096","after":"5f50b1e3bf710b4107eb38496d932b3d9bd1fc98","ref":"refs/heads/master","pushedAt":"2024-07-03T18:07:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: fix mis-compilation when switching over channels\n\nCL 418101 changes Unified IR writer to force mixed tag/case to have\ncommon type, emitting the implicit conversion if any of the case values\nare not assignable to the tag value's type.\n\nHowever, the Go spec definition of equality is non-transitive for\nchannels stored in interfaces, causing incorrect behavior with channel\nvalues comparison.\n\nTo fix it, don't emit the implicit conversions if tag type is channel.\n\nFixes #67190\n\nChange-Id: I9a29d9ce3c7978f0689e9502ba6f15660c763d16\nReviewed-on: https://go-review.googlesource.com/c/go/+/594575\nAuto-Submit: Cuong Manh Le \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: fix mis-compilation when switching over channels"}},{"before":"148755a27b50134d1db72c3c0bdf500815569531","after":"71f9dbb1e409a28680f40c60fad5a386ed92a096","ref":"refs/heads/master","pushedAt":"2024-07-03T13:03:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: emit error message on mismatch import path\n\nFixes #54542\n\nChange-Id: I16cfb84fc54892923106d0a6f0b3ba810886d077\nReviewed-on: https://go-review.googlesource.com/c/go/+/596396\nAuto-Submit: Cuong Manh Le \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: emit error message on mismatch import path"}},{"before":"f12ac5be7045efcde39025c32cc01a20a305012c","after":"148755a27b50134d1db72c3c0bdf500815569531","ref":"refs/heads/master","pushedAt":"2024-07-03T00:15:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: document -checklinkname option\n\nFor #67401\n\nChange-Id: I04bff1c942a4033325450c0b7dddc7980f3373cc\nReviewed-on: https://go-review.googlesource.com/c/go/+/596216\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/link: document -checklinkname option"}},{"before":"09aeb6e33ab426eff4676a3baf694d5a3019e9fc","after":"f12ac5be7045efcde39025c32cc01a20a305012c","ref":"refs/heads/master","pushedAt":"2024-07-02T20:02:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"time: fix time zone parsing when format includes time zone seconds\n\nThe current implementation fails to parse a time string with a \"Z\"\ntime zone using a time format that includes time zone seconds. This\nfix correctly parses the \"Z\" time zone for any Z-base time format\nthat includes seconds (i.e. \"Z070000\" or \"Z07:00:00\").\n\nFixes #68263\n\nChange-Id: Idf8fa06b5f96383f050c4ffbd2bc5804fd408650\nReviewed-on: https://go-review.googlesource.com/c/go/+/595897\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"time: fix time zone parsing when format includes time zone seconds"}},{"before":"c9be6ae748b7679b644a38182d456cb5a6ac06ee","after":"12e9b968bc8890b072b98facbd079ca337bd33a0","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-07-02T18:52:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] go1.21.12\n\nChange-Id: I5d0af46471907bc3d28f18348bb208689e4d9949\nReviewed-on: https://go-review.googlesource.com/c/go/+/596256\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Than McIntosh \nAuto-Submit: Gopher Robot ","shortMessageHtmlLink":"[release-branch.go1.21] go1.21.12"}},{"before":"c2d4f852ce69fc2674d45ccd3090757dd01cc2d4","after":"8e1fdea8316d840fd07e9d6e026048e53290948b","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-07-02T18:52:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] go1.22.5\n\nChange-Id: Ibc28cd85275c5a1c943b0d052b6adc4425ab5165\nReviewed-on: https://go-review.googlesource.com/c/go/+/596255\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nAuto-Submit: Gopher Robot \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"[release-branch.go1.22] go1.22.5"}},{"before":"94982a07825aec711f11c97283e99e467838d616","after":"09aeb6e33ab426eff4676a3baf694d5a3019e9fc","ref":"refs/heads/master","pushedAt":"2024-07-02T12:36:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: add TODO about removing test exception\n\nTestChtimesOmit excludes the failure on DragonFly BSD when both\natime and mtime are omitted.\n\nThe relevant Dragonfly BSD bug is now fixed in git (see [1]).\n\nAdd a TODO comment to remove the exclusion from the test once\nthe fix is generally available. This comment also addresses the\nquestion why the exception exists.\n\nAmends CL 591535.\n\n[1]: https://github.com/DragonFlyBSD/DragonFlyBSD/commit/c7c71870ed0\n\nChange-Id: I3b53582301d44feb76b53788aa337c380ba82592\nReviewed-on: https://go-review.googlesource.com/c/go/+/595958\nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"os: add TODO about removing test exception"}},{"before":"f71c00b6165177dbcc5d40ff5f4731d297ee6090","after":"94982a07825aec711f11c97283e99e467838d616","ref":"refs/heads/master","pushedAt":"2024-07-01T19:41:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/workcmd: remove a potentially confusing statement\n\nA statement in the go work use docs that was meant to clarify that go\nwork use would clean up use statements where the directories did not\nexist ended up causing confusion.\n\nRemove that statement for now. We might want to add something back in\nthe future.\n\nFor #68245\n\nChange-Id: I7f6646b5dd05c18aa15e0e54f2816753f318404e\nReviewed-on: https://go-review.googlesource.com/c/go/+/595536\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Eli Bendersky ","shortMessageHtmlLink":"cmd/go/internal/workcmd: remove a potentially confusing statement"}},{"before":"d3c93f2f00fe40eb6f8b0bf9c81b15ddd9872119","after":"f71c00b6165177dbcc5d40ff5f4731d297ee6090","ref":"refs/heads/master","pushedAt":"2024-07-01T19:16:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: align .reloc block starts by 32 bits for PE target\n\nTweak the code that emits the PE \".reloc\" section on Windows to ensure\nthat each relocation block is 32-bit aligned, which is required by the\nPE standard.\n\nFixes #68260.\n\nChange-Id: I39b75a7491b00fa97871aebb90d3be0ec09f9c40\nReviewed-on: https://go-review.googlesource.com/c/go/+/595896\nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link: align .reloc block starts by 32 bits for PE target"}},{"before":"cdbf5f2f7e968993560730479d4670c2d6eecd8b","after":"d3c93f2f00fe40eb6f8b0bf9c81b15ddd9872119","ref":"refs/heads/master","pushedAt":"2024-07-01T14:58:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: update go clean help message\n\nUpdate the help message for the go clean command to include\nthe correct usage and flags for better clarity.\n\nThis change follows instructions by Ian on this thread .\n\nChange-Id: Ia509a38ee9ec7c31d384c3563535c5e3ccd9a9ce\nGitHub-Last-Rev: 3048b2e4bd10a8d25da479f96c9d90ecb3c63082\nGitHub-Pull-Request: golang/go#68135\nReviewed-on: https://go-review.googlesource.com/c/go/+/593639\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Matloob \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/go: update go clean help message"}},{"before":"c33144c47cbee5506df404553c3769867972f889","after":"cdbf5f2f7e968993560730479d4670c2d6eecd8b","ref":"refs/heads/master","pushedAt":"2024-07-01T13:44:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sync: refer to Locker interface methods in RWMutex.RLocker doc\n\nThe methods being implemented are part of the Locker interface,\nnot the RWMutex struct.\n\nFixes #68250.\n\nChange-Id: I609c4d5c44e90a12914a8678971ba295519cc265\nReviewed-on: https://go-review.googlesource.com/c/go/+/595875\nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"sync: refer to Locker interface methods in RWMutex.RLocker doc"}},{"before":"82c371a307116450e9ab4dbce1853da3e69f4061","after":"c33144c47cbee5506df404553c3769867972f889","ref":"refs/heads/master","pushedAt":"2024-07-01T13:41:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"runtime: fix nil pointer in TestGoroutineParallelism2 when offline\n\nPreviously, the test would crash when running on a computer without an\ninternet connection, e.g. in airplane mode (stack trace below).\n\nThe bug was that the condition was inverted. The code tried to close\nthe listener if `err != nil` (that is, if net.Listen() failed). But if\nListen() failed then there is no listener to close! The listener\nshould only be closed if Listen() succeeded.\n\nHere is the stack trace from `go test runtime` when offline:\n\n```\n--- FAIL: TestGoroutineParallelism2 (0.16s)\npanic: runtime error: invalid memory address or nil pointer dereference [recovered]\n\tpanic: runtime error: invalid memory address or nil pointer dereference\n[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7bdaa1]\n\ngoroutine 3858 gp=0xc000185180 m=5 mp=0xc000100008 [running]:\npanic({0x854960?, 0xbf70b0?})\n\t/src/runtime/panic.go:778 +0x168 fp=0xc0000afad8 sp=0xc0000afa28 pc=0x441bc8\ntesting.tRunner.func1.2({0x854960, 0xbf70b0})\n\t/src/testing/testing.go:1632 +0x230 fp=0xc0000afb88 sp=0xc0000afad8 pc=0x524090\ntesting.tRunner.func1()\n\t/src/testing/testing.go:1635 +0x35e fp=0xc0000afd18 sp=0xc0000afb88 pc=0x523a7e\npanic({0x854960?, 0xbf70b0?})\n\t/src/runtime/panic.go:759 +0x132 fp=0xc0000afdc8 sp=0xc0000afd18 pc=0x441b92\nruntime.panicmem(...)\n\t/src/runtime/panic.go:261\nruntime.sigpanic()\n\t/src/runtime/signal_unix.go:900 +0x359 fp=0xc0000afe28 sp=0xc0000afdc8 pc=0x483c79\nruntime_test.testGoroutineParallelism2(0x522e13?, 0x0, 0x1)\n\t/src/runtime/proc_test.go:204 +0x221 fp=0xc0000aff50 sp=0xc0000afe28 pc=0x7bdaa1\nruntime_test.TestGoroutineParallelism2(0xc000221520)\n\t/src/runtime/proc_test.go:151 +0x30 fp=0xc0000aff70 sp=0xc0000aff50 pc=0x7bd850\ntesting.tRunner(0xc000221520, 0x8fed88)\n\t/src/testing/testing.go:1690 +0xf4 fp=0xc0000affc0 sp=0xc0000aff70 pc=0x523674\ntesting.(*T).Run.gowrap1()\n\t/src/testing/testing.go:1743 +0x25 fp=0xc0000affe0 sp=0xc0000affc0 pc=0x524665\nruntime.goexit({})\n\t/src/runtime/asm_amd64.s:1700 +0x1 fp=0xc0000affe8 sp=0xc0000affe0 pc=0x487a41\ncreated by testing.(*T).Run in goroutine 1\n\t/src/testing/testing.go:1743 +0x390\n```\n\nChange-Id: I48983fe21b3360ea9d0182c4a3b509801257027b\nReviewed-on: https://go-review.googlesource.com/c/go/+/584436\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall \nReviewed-by: Than McIntosh \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"runtime: fix nil pointer in TestGoroutineParallelism2 when offline"}},{"before":"773767def0e0f29584a69bd760430167b7479d7d","after":"82c371a307116450e9ab4dbce1853da3e69f4061","ref":"refs/heads/master","pushedAt":"2024-06-28T20:00:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: drop internal range-over-func vars from DWARF output\n\nDrops internal range-over-func variables from the DWARF output\n(excluding #yield which is used by Delve).\n\nFixes #68238\n\nChange-Id: Ic035e37ca3560347276cdc3b469fd564da33f4f5\nReviewed-on: https://go-review.googlesource.com/c/go/+/594257\nReviewed-by: Than McIntosh \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Hyang-Ah Hana Kim \nAuto-Submit: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"cmd/compile: drop internal range-over-func vars from DWARF output"}},{"before":"7f90b960a9711b51bf36f49be4274ac5f7e86a95","after":"773767def0e0f29584a69bd760430167b7479d7d","ref":"refs/heads/master","pushedAt":"2024-06-28T17:01:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net/http: avoid appending an existing trailing slash to path again\n\nThis CL is similar to CL 562557, and it takes over CL 594175.\n\nWhile here, unrelatedly remove mapKeys function, use slices.Sorted(maps.Keys(ms))\nto simplify code.\n\nFixes #67657\n\nChange-Id: Id8b99216f87a6dcfd6d5fa61407b515324c79112\nReviewed-on: https://go-review.googlesource.com/c/go/+/594737\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam \nReviewed-by: Joedian Reid ","shortMessageHtmlLink":"net/http: avoid appending an existing trailing slash to path again"}},{"before":"ea537cca314d9da5365eeefcc375410c76e93b36","after":"7f90b960a9711b51bf36f49be4274ac5f7e86a95","ref":"refs/heads/master","pushedAt":"2024-06-28T15:26:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: don't elide zero extension on top of signed values\n\nv = ... compute some value, which zeros top 32 bits ...\nw = zero-extend v\n\nWe want to remove the zero-extension operation, as it doesn't do anything.\nBut if v is typed as a signed value, and it gets spilled/restored, it\nmight be re-sign-extended upon restore. So the zero-extend isn't actually\na NOP when there might be calls or other reasons to spill in between v and w.\n\nFixes #68227\n\nChange-Id: I3b30b8e56c7d70deac1fb09d2becc7395acbadf8\nReviewed-on: https://go-review.googlesource.com/c/go/+/595675\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Joedian Reid \nReviewed-by: Cuong Manh Le \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"cmd/compile: don't elide zero extension on top of signed values"}},{"before":"b0927fdd494a79458ff151ce8db59963f67b80be","after":"ea537cca314d9da5365eeefcc375410c76e93b36","ref":"refs/heads/master","pushedAt":"2024-06-27T17:42:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/help: add documentation for language version downgrading\n\nThis change adds documentation for language version downgrading using\nbuild constraints.\n\nFixes #68161\nFor #61894\n\nChange-Id: I283a51afd7020c9fd1f5469a6a93fd814ba32f7e\nReviewed-on: https://go-review.googlesource.com/c/go/+/595475\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go/internal/help: add documentation for language version downgrading"}},{"before":"5a18e79687dea15680ff5f799b549fa0efd0cad9","after":"b0927fdd494a79458ff151ce8db59963f67b80be","ref":"refs/heads/master","pushedAt":"2024-06-27T17:18:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"slices: update docs for All, Backward, Values\n\nFor #61899\n\nChange-Id: I3586b9b59e87159d21e1a270dabb3af213592739\nReviewed-on: https://go-review.googlesource.com/c/go/+/595515\nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"slices: update docs for All, Backward, Values"}},{"before":"ceaf26ecce663e75c4f4b476dc3c64fa58a2f0dd","after":"c2d4f852ce69fc2674d45ccd3090757dd01cc2d4","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-26T22:23:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/link: handle dynamic import variables on Darwin in plugin mode\n\nCL 501855 added support for cgo_dynamic_import variables on Darwin.\nBut it didn't support the plugin build mode on amd64, where the\nassembler turns a direct load (R_PCREL) to a load via GOT\n(R_GOTPCREL). This CL adds the support. We just need to handle\nexternal linking mode, as this can only occur in plugin or shared\nbuild mode, which requires external linking.\n\nFixes #68122.\nUpdates #67976.\nUpdates #50891.\n\nChange-Id: I0f56265d50bfcb36047fa5538ad7a5ec77e7ef96\nReviewed-on: https://go-review.googlesource.com/c/go/+/592499\nReviewed-by: David Chase \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit 44f18706661db8b865719d15a5cfa0515d1a4fca)\nReviewed-on: https://go-review.googlesource.com/c/go/+/595175\nReviewed-by: Joedian Reid \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"[release-branch.go1.22] cmd/link: handle dynamic import variables on …"}},{"before":"ac14d4d9cea31109b475bdba3cc8afd823a07c21","after":"c9be6ae748b7679b644a38182d456cb5a6ac06ee","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-26T22:23:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] net/http: send body or close connection on expect-100-continue requests\n\nWhen sending a request with an \"Expect: 100-continue\" header,\nwe must send the request body before sending any further requests\non the connection.\n\nWhen receiving a non-1xx response to an \"Expect: 100-continue\" request,\nsend the request body if the connection isn't being closed after\nprocessing the response. In other words, if either the request\nor response contains a \"Connection: close\" header, then skip sending\nthe request body (because the connection will not be used for\nfurther requests), but otherwise send it.\n\nCorrect a comment on the server-side Expect: 100-continue handling\nthat implied sending the request body is optional. It isn't.\n\nFor #67555\nFixes #68199\n\nChange-Id: Ia2f12091bee697771087f32ac347509ec5922d54\nReviewed-on: https://go-review.googlesource.com/c/go/+/591255\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam \n(cherry picked from commit cf501e05e138e6911f759a5db786e90b295499b9)\nReviewed-on: https://go-review.googlesource.com/c/go/+/595096\nReviewed-by: Joedian Reid \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"[release-branch.go1.21] net/http: send body or close connection on ex…"}},{"before":"5f319b75075a62ab176ab8c25f0e45f2ae4f0704","after":"5a18e79687dea15680ff5f799b549fa0efd0cad9","ref":"refs/heads/master","pushedAt":"2024-06-26T16:18:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: don't skip code sign even if dsymutil didn't generate a file\n\nEven if dsymutil didn't generate a file (which should not happen\nwith the Apple toolchain with the correct setup), we should not\nskip next steps, e.g. code sign. A return statement makes it exit\ntoo early.\n\nUpdates #68088.\n\nChange-Id: Ic1271ed1b7fe5bdee5a25cc5d669a105173b389e\nReviewed-on: https://go-review.googlesource.com/c/go/+/593660\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/link: don't skip code sign even if dsymutil didn't generate a file"}},{"before":"a2e90be996fb0e75966b1e1097dd20aa07eebc37","after":"5f319b75075a62ab176ab8c25f0e45f2ae4f0704","ref":"refs/heads/master","pushedAt":"2024-06-26T16:17:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: don't let dsymutil delete our temp directory\n\nTo work around #59026, where dsymutil may not clean up its temp\ndirectory at exit, we set DSYMUTIL_REPRODUCER_PATH to our temp\ndirectory so it uses that, and we can delete it at the end.\n\nIn Xcode 16 beta, dsymutil deletes the DSYMUTIL_REPRODUCER_PATH\ndirectory even if it is not empty. We still need our tmpdir at the\npoint, so give a subdirectory to dsymutil instead.\n\nFor #68088.\n\nChange-Id: I18759cc39512819bbd0511793ce917eae72245d6\nReviewed-on: https://go-review.googlesource.com/c/go/+/593659\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link: don't let dsymutil delete our temp directory"}},{"before":"90bcc552c0347948166817a602f612f219bc980c","after":"a2e90be996fb0e75966b1e1097dd20aa07eebc37","ref":"refs/heads/master","pushedAt":"2024-06-26T16:11:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: rewrite TestChtimesWithZeroTimes\n\nFirst, this enables checks on DragonFly BSD, which partially works since\nCL 589496 (except two things: atime is not supported on hammer2 fs, and\nwhen both times are omitted, it doesn't work due to a kernel bug).\n\nSecond, there are a few problems with TestChtimesWithZeroTimes:\n\n - test cases are interdependent (former cases influence the latter ones),\n making the test using too many different times and also hard to read;\n\n - time is changed forward not backward which could be racy;\n\n - if the test has failed, it hard to see which exact case is failing.\n\nPlus, there are issues with the error exclusion code in\nTestChtimesWithZeroTimes:\n\n - the atime comparison is done twice for the default (\"unix\") case;\n\n - the atime exclusion caused by noatime mount flag applies to all\n unixes rather than netbsd only as it should;\n\n - the atime exclusion tries to read wrong files (/bin/mounts and\n /etc/mtab instead of /proc/mounts);\n\n - the exclusion for netbsd is only applied for 64-bit arches, which\n seems wrong (and I've reproduced noatime issue on NetBSD 9.4/i386).\n\nLet's rewrite it, fixing all these issues, and rename to\nTestChtimesOmit.\n\nNB: TestChtimes can now be removed.\n\nChange-Id: If9020256ca920b4db836a1f0b2e055b5fce4a552\nReviewed-on: https://go-review.googlesource.com/c/go/+/591535\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nReviewed-by: Joedian Reid \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"os: rewrite TestChtimesWithZeroTimes"}},{"before":"dfe4dbf8c055f79758ce7ae3d3ab2d0e4a0ea9ee","after":"ceaf26ecce663e75c4f4b476dc3c64fa58a2f0dd","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-26T14:01:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg\n\nWhen the compiler writes PtrToThis field of noalg type, it generates\nits pointer type. Mark them as noalg to prevent put them in typelinks.\n\nFixes #65983\n\nChange-Id: Icbc3b18bc866f9138c7648e42dd500a80326f72b\nReviewed-on: https://go-review.googlesource.com/c/go/+/567335\nReviewed-by: Matthew Dempsky \nAuto-Submit: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall \n(cherry picked from commit b8c76effd9a3a30d66e44ed7acea789e4e95b926)\nReviewed-on: https://go-review.googlesource.com/c/go/+/593876\nReviewed-by: David Chase ","shortMessageHtmlLink":"[release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg"}},{"before":"b1fd047508aad9f5038dc04d78146cc582328bf5","after":"90bcc552c0347948166817a602f612f219bc980c","ref":"refs/heads/master","pushedAt":"2024-06-25T17:08:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"crypto/tls: apply QUIC session event flag to QUICResumeSession events\n\nGo 1.23 adds two new events to QUICConns: QUICStoreSessionEvent and\nQUICResumeSessionEvent. We added a QUICConfig.EnableStoreSessionEvent\nflag to control whether the store-session event is provided or not,\nbecause receiving this event requires additional action from the caller:\nthe session must be explicitly stored with QUICConn.StoreSession.\n\nWe did not add a control for whether the resume-session event is\nprovided, because this event requires no action and the caller is\nexpected to ignore unknown events.\n\nHowever, we never documented the expectation that callers ignore\nunknown events, and quic-go produces an error when receiving an\nunexpected event. So change the EnableStoreSessionEvent flag to\napply to both new events.\n\nFixes #68124\nFor #63691\n\nChange-Id: I84af487e52b3815f7b648e09884608f8915cd645\nReviewed-on: https://go-review.googlesource.com/c/go/+/594475\nReviewed-by: Marten Seemann \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Roland Shoemaker ","shortMessageHtmlLink":"crypto/tls: apply QUIC session event flag to QUICResumeSession events"}},{"before":"b3b4556c245c8f21872910ee866133428bbb5a60","after":"b1fd047508aad9f5038dc04d78146cc582328bf5","ref":"refs/heads/master","pushedAt":"2024-06-25T14:29:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/internal/obj/arm64: fix return with register\n\nARM64 allows for a register to be specified with a return\ninstruction. While the assembler parsing and encoding currently\nsupports this, the preprocess function uses LR unconditionally.\nCorrect this such that if a register is specified, the register\nis used.\n\nChange-Id: I708f6c7e910d141559b60d2d5ee76ae2e1dc3a0e\nReviewed-on: https://go-review.googlesource.com/c/go/+/592796\nReviewed-by: Cherry Mui \nReviewed-by: David Chase \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/internal/obj/arm64: fix return with register"}},{"before":"68315bc8ce8c7fd1a9e47e73b2d18ef21f8c6d9a","after":"b3b4556c245c8f21872910ee866133428bbb5a60","ref":"refs/heads/master","pushedAt":"2024-06-25T00:12:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: update README to reflect dead code elimination changes\n\nThe description of middle-end dead code elimination is inconsistent with the current implementation.\n\nThe early dead code elimination pass of IR nodes is no longer located in cmd/compile/internal/deadcode and is no longer called by gc/main.go:Main. It has been moved to the unified IR writer phase. This update modifies the README to reflect this architectural change.\n\nChange-Id: I78bd486edefd6b02948fee7de9ce6c83b147bc1d\nGitHub-Last-Rev: 76493ce8b08cd585d761d65d29b984360f7ee628\nGitHub-Pull-Request: golang/go#68134\nReviewed-on: https://go-review.googlesource.com/c/go/+/593638\nReviewed-by: Robert Griesemer \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Keith Randall ","shortMessageHtmlLink":"cmd/compile: update README to reflect dead code elimination changes"}},{"before":"f214a760754ac0584999fb8098ce6172181ed791","after":"68315bc8ce8c7fd1a9e47e73b2d18ef21f8c6d9a","ref":"refs/heads/master","pushedAt":"2024-06-24T21:08:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd: run go mod tidy after CL 593684\n\nReported by TestAllDependencies/cmd(thorough) in cmd/internal/moddeps.\n\nChange-Id: I897baf00efbfebd07abe387f54c7ce4fc14444e6\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/go/+/594536\nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Hyang-Ah Hana Kim \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd: run go mod tidy after CL 593684"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEd7I_4AA","startCursor":null,"endCursor":null}},"title":"Activity · golang/go"}