Fix Clippy lints (#957)

This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.

src/lib.rs

@@ -8301,13 +8301,15 @@ mod tests {
             pub(super) struct AutorefWrapper<T: ?Sized>(pub(super) PhantomData<T>);
 
             pub(super) trait TestIsBitValidShared<T: ?Sized> {
+                #[allow(clippy::needless_lifetimes)]
                 fn test_is_bit_valid_shared<'ptr, A: invariant::at_least::Shared>(
                     &self,
                     candidate: Maybe<'ptr, T, A>,
                 ) -> Option<bool>;
             }
 
             impl<T: TryFromBytes + NoCell + ?Sized> TestIsBitValidShared<T> for AutorefWrapper<T> {
+                #[allow(clippy::needless_lifetimes)]
                 fn test_is_bit_valid_shared<'ptr, A: invariant::at_least::Shared>(
                     &self,
                     candidate: Maybe<'ptr, T, A>,
@@ -8317,25 +8319,29 @@ mod tests {
             }
 
             pub(super) trait TestTryFromRef<T: ?Sized> {
+                #[allow(clippy::needless_lifetimes)]
                 fn test_try_from_ref<'bytes>(
                     &self,
                     bytes: &'bytes [u8],
                 ) -> Option<Option<&'bytes T>>;
 
+                #[allow(clippy::needless_lifetimes)]
                 fn test_try_from_mut<'bytes>(
                     &self,
                     bytes: &'bytes mut [u8],
                 ) -> Option<Option<&'bytes mut T>>;
             }
 
             impl<T: TryFromBytes + NoCell + KnownLayout + ?Sized> TestTryFromRef<T> for AutorefWrapper<T> {
+                #[allow(clippy::needless_lifetimes)]
                 fn test_try_from_ref<'bytes>(
                     &self,
                     bytes: &'bytes [u8],
                 ) -> Option<Option<&'bytes T>> {
                     Some(T::try_from_ref(bytes))
                 }
 
+                #[allow(clippy::needless_lifetimes)]
                 fn test_try_from_mut<'bytes>(
                     &self,
                     bytes: &'bytes mut [u8],
@@ -8357,10 +8363,12 @@ mod tests {
             }
 
             pub(super) trait TestAsBytes<T: ?Sized> {
+                #[allow(clippy::needless_lifetimes)]
                 fn test_as_bytes<'slf, 't>(&'slf self, t: &'t T) -> Option<&'t [u8]>;
             }
 
             impl<T: IntoBytes + NoCell + ?Sized> TestAsBytes<T> for AutorefWrapper<T> {
+                #[allow(clippy::needless_lifetimes)]
                 fn test_as_bytes<'slf, 't>(&'slf self, t: &'t T) -> Option<&'t [u8]> {
                     Some(t.as_bytes())
                 }
@@ -8407,6 +8415,7 @@ mod tests {
                 // implementations defined in the `autoref_trick` module above.
                 #[allow(unused)]
                 impl AutorefWrapper<$ty> {
+                    #[allow(clippy::needless_lifetimes)]
                     fn test_is_bit_valid_shared<'ptr, A: invariant::at_least::Shared>(
                         &mut self,
                         candidate: Maybe<'ptr, $ty, A>,
@@ -8424,6 +8433,7 @@ mod tests {
                         None
                     }
 
+                    #[allow(clippy::needless_lifetimes)]
                     fn test_try_from_ref<'bytes>(&mut self, _bytes: &'bytes [u8]) -> Option<Option<&'bytes $ty>> {
                         assert_on_allowlist!(
                             test_try_from_ref($ty):
@@ -8433,6 +8443,7 @@ mod tests {
                         None
                     }
 
+                    #[allow(clippy::needless_lifetimes)]
                     fn test_try_from_mut<'bytes>(&mut self, _bytes: &'bytes mut [u8]) -> Option<Option<&'bytes mut $ty>> {
                         assert_on_allowlist!(
                             test_try_from_mut($ty):

src/pointer/ptr.rs

@@ -516,6 +516,7 @@ mod _conversions {
         /// methods from being called on `self` as long as the returned `Ptr`
         /// exists.
         #[doc(hidden)]
+        #[inline]
         #[allow(clippy::needless_lifetimes)] // Allows us to name the lifetime in the safety comment below.
         pub fn reborrow<'b>(&'b mut self) -> Ptr<'b, T, I>
         where
@@ -691,15 +692,17 @@ mod _transitions {
                 let t = t.as_bytes();
 
                 let mut i = 0;
+                #[allow(clippy::arithmetic_side_effects)]
                 while i < s.len() {
+                    #[allow(clippy::indexing_slicing)]
                     if s[i] != t[i] {
                         return false;
                     }
 
                     i += 1;
                 }
 
-                return true;
+                true
             }
 
             assert!(I::Aliasing::IS_EXCLUSIVE);