Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming as_bytes_mut to as_mut_bytes #253

Closed
joshlf opened this issue Aug 12, 2023 · 0 comments · Fixed by #870
Closed

Consider renaming as_bytes_mut to as_mut_bytes #253

joshlf opened this issue Aug 12, 2023 · 0 comments · Fixed by #870
Labels
compatibility-breaking Changes that are (likely to be) breaking

Comments

@joshlf
Copy link
Member

joshlf commented Aug 12, 2023

This would be consistent with the naming convention used elsewhere in the ecosystem such as in Vec::as_mut_slice. We also should do this for any other similarly-named methods/functions.
@joshlf joshlf added the compatibility-breaking Changes that are (likely to be) breaking label Aug 12, 2023
@joshlf joshlf mentioned this issue Aug 20, 2023
Open
@joshlf joshlf mentioned this issue Dec 4, 2023
Open
65 tasks
@dorryspears dorryspears mentioned this issue Feb 12, 2024
Merged
dorryspears added a commit to dorryspears/zerocopy that referenced this issue Feb 13, 2024
@dorryspears
Rename as_bytes_mut to as_mut_bytes Fixes google#253
bff9148
dorryspears added a commit to dorryspears/zerocopy that referenced this issue Feb 13, 2024
@dorryspears
Rename as_bytes_mut to as_mut_bytes
0347a27 
Fixes google#253
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2024
@dorryspears
Rename as_bytes_mut to as_mut_bytes (#870)
82f03fc 
Fixes #253
@joshlf joshlf mentioned this issue Feb 13, 2024
Open
13 tasks
dorryspears added a commit to dorryspears/zerocopy that referenced this issue Feb 20, 2024
@dorryspears
Rename as_bytes_mut to as_mut_bytes (google#870)
284bf83 
Fixes google#253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-breaking Changes that are (likely to be) breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed as_bytes_mut to as_mut_bytes dorryspears/zerocopy
1 participant
@joshlf