Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git pre-push hook #403

Closed
joshlf opened this issue Sep 19, 2023 · 3 comments
Closed

Add git pre-push hook #403

joshlf opened this issue Sep 19, 2023 · 3 comments
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking experience-medium This issue is of medium difficulty, and requires some experience help wanted Extra attention is needed

Comments

@joshlf
Copy link
Member

joshlf commented Sep 19, 2023

Some of our tests are very cheap to run, and it would tighten the development loop if these tests could catch easy mistakes before pushing rather than needing to wait for CI to catch them. Likely this includes:

  • check_fmt
  • check_readme
  • check_msrv
  • check_versions
@joshlf joshlf added help wanted Extra attention is needed experience-medium This issue is of medium difficulty, and requires some experience compatibility-nonbreaking Changes that are (likely to be) non-breaking labels Sep 19, 2023
@tommy-gilligan
Copy link
Contributor

Currently these are inline in YAML. Is there a preferred place for extracting these as individual scripts?

@tommy-gilligan
Copy link
Contributor

#728

@joshlf
Copy link
Member Author

joshlf commented Mar 5, 2024

Closed in #728

@joshlf joshlf closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking experience-medium This issue is of medium difficulty, and requires some experience help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshlf @tommy-gilligan