Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable and nightly toolchain roller failing #947

Closed
joshlf opened this issue Feb 26, 2024 · 2 comments
Closed

Stable and nightly toolchain roller failing #947

joshlf opened this issue Feb 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@joshlf
Copy link
Member

joshlf commented Feb 26, 2024

https://github.com/google/zerocopy/actions/runs/8030574585
@joshlf joshlf added the bug Something isn't working label Feb 26, 2024
@jswrenn
Copy link
Collaborator

jswrenn commented Feb 26, 2024 •
edited

This is occurring because the Rust replacement to ./cargo.sh is not setting its exit code appropriately depending on the outcome of its inner invocation. Its exit code is always 0, and so Github Actions considers all of our CI steps to have unconditionally passed.

cc @djkoloski

@djkoloski djkoloski mentioned this issue Feb 26, 2024
Merged
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
Make Ptr::reborrow public
5a2074a 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
Make Ptr::reborrow public
34b11f0 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@joshlf
Make Ptr::reborrow public (#949)
ae1182e 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
Fix some uses of FromBytes and NoCell in doc tests
b5d4181 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@joshlf
Fix some uses of FromBytes and NoCell in doc tests (#950)
296999d 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
Fix UI tests
8ba25f0 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

While we're here, add an `assert!` that prevents us from running UI
tests when the `derive` feature is disabled. The `derive` feature is
required in order for UI tests to produce sensible output, and running
without it enabled is a common source of mis-steps when developing that
ends up slowing us down.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@joshlf
Fix UI tests (#951)
2e2eaa7 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

While we're here, add an `assert!` that prevents us from running UI
tests when the `derive` feature is disabled. The `derive` feature is
required in order for UI tests to produce sensible output, and running
without it enabled is a common source of mis-steps when developing that
ends up slowing us down.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
[derive] Fix UI tests
9d199db 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
[derive] Fix UI tests
dbd5238 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@joshlf
[derive] Fix UI tests (#954)
9421346 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
Fix some uses of NoCell in doc tests
fdff237 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
This was referenced Feb 26, 2024
Merged
Merged
joshlf added a commit that referenced this issue Feb 26, 2024
@joshlf
Fix some uses of NoCell in doc tests
1626ba5 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@joshlf
Fix some uses of NoCell in doc tests (#956)
a309a36 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@joshlf
Fix Clippy lints (#957)
40b550e 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf
Copy link
Member Author

joshlf commented Feb 27, 2024

Fixed in a bunch of PRs culminating in #948.

@joshlf joshlf closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshlf @jswrenn