-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable and nightly toolchain roller failing #947
Labels
bug
Something isn't working
Comments
This is occurring because the Rust replacement to cc @djkoloski |
joshlf
added a commit
that referenced
this issue
Feb 26, 2024
This shouldn't have made it onto `main`, but was able to as a result of the bug described in #947. While we're here, add an `assert!` that prevents us from running UI tests when the `derive` feature is disabled. The `derive` feature is required in order for UI tests to produce sensible output, and running without it enabled is a common source of mis-steps when developing that ends up slowing us down. This will need to merge before #948 can merge.
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 26, 2024
This shouldn't have made it onto `main`, but was able to as a result of the bug described in #947. While we're here, add an `assert!` that prevents us from running UI tests when the `derive` feature is disabled. The `derive` feature is required in order for UI tests to produce sensible output, and running without it enabled is a common source of mis-steps when developing that ends up slowing us down. This will need to merge before #948 can merge.
Merged
This was referenced Feb 26, 2024
Merged
Fixed in a bunch of PRs culminating in #948. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/google/zerocopy/actions/runs/8030574585
The text was updated successfully, but these errors were encountered: