[githooks] CI scripts pipe failures to stderr #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, some scripts had output which would only be generated on failure, but this output was passed to stdout, which `githooks/pre-push` pipes to `/dev/null`. In this commit, any such output is unconditionally redirected to `stderr` - if there's any output, we want to see it. This previously resulted in very opaque errors during `git push`, which should be addressed by this commit. Also, in #728, we added `ci/check_all_toolchains_tested.sh`, but didn't add it to `githooks/pre-push`. In this commit, we fix that, and also add a test to `githooks/pre-push` to validate that all scripts in `ci/*` at least show up in `githooks/pre-push` by name. This isn't a foolproof check, but it should catch obvious errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
=======================================
Coverage 87.79% 87.79%
=======================================
Files 15 15
Lines 5171 5171
=======================================
Hits 4540 4540
Misses 631 631 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some scripts had output which would only be generated on failure, but this output was passed to stdout, which
githooks/pre-pushpipes to/dev/null. In this commit, any such output is unconditionally redirected tostderr- if there's any output, we want to see it. This previously resulted in very opaque errors duringgit push, which should be addressed by this commit.Also, in #728, we added
ci/check_all_toolchains_tested.sh, but didn't add it togithooks/pre-push. In this commit, we fix that, and also add a test togithooks/pre-pushto validate that all scripts inci/*at least show up ingithooks/pre-pushby name. This isn't a foolproof check, but it should catch obvious errors.