From ab2221a019a8ceeda661f2dbdbb1007442e30ab2 Mon Sep 17 00:00:00 2001 From: Peter Lauck Date: Mon, 11 Dec 2023 15:33:08 +0000 Subject: [PATCH] feat(reviews)!: move error matcher injection token to state subpackage (#2645) BREAKING CHANGE: error matcher injection token has moved to state subpackage --- libs/reviews/src/public_api.ts | 1 - .../src/effects/product-page-review-collection.effects.ts | 6 ++---- .../state/src/effects/product-page-reviews.effects.ts | 6 ++---- .../{ => state}/src/injection-tokens/error-matcher.token.ts | 0 libs/reviews/{ => state}/src/injection-tokens/public_api.ts | 0 libs/reviews/state/src/public_api.ts | 1 + 6 files changed, 5 insertions(+), 9 deletions(-) rename libs/reviews/{ => state}/src/injection-tokens/error-matcher.token.ts (100%) rename libs/reviews/{ => state}/src/injection-tokens/public_api.ts (100%) diff --git a/libs/reviews/src/public_api.ts b/libs/reviews/src/public_api.ts index be8edb266f..15a170da9d 100644 --- a/libs/reviews/src/public_api.ts +++ b/libs/reviews/src/public_api.ts @@ -1,2 +1 @@ export * from './models/public_api'; -export * from './injection-tokens/public_api'; diff --git a/libs/reviews/state/src/effects/product-page-review-collection.effects.ts b/libs/reviews/state/src/effects/product-page-review-collection.effects.ts index 06f4b74e0b..babbdabbcc 100644 --- a/libs/reviews/state/src/effects/product-page-review-collection.effects.ts +++ b/libs/reviews/state/src/effects/product-page-review-collection.effects.ts @@ -25,10 +25,7 @@ import { } from '@daffodil/core'; import { ErrorTransformer } from '@daffodil/core/state'; import { DaffProductPageFacade } from '@daffodil/product/state'; -import { - DaffProductReview, - DAFF_REVIEWS_ERROR_MATCHER, -} from '@daffodil/reviews'; +import { DaffProductReview } from '@daffodil/reviews'; import { DaffProductReviewsServiceInterface, DaffReviewsDriver, @@ -41,6 +38,7 @@ import { DaffReviewsProductListSuccess, } from '../actions/public_api'; import { DaffProductPageReviewsCollectionFacade } from '../facades/public_api'; +import { DAFF_REVIEWS_ERROR_MATCHER } from '../injection-tokens/public_api'; export const DAFF_PRODUCT_REVIEW_COLLECTION_ACTION_TYPES = [ DaffProductReviewsCollectionActionTypes.ChangeCurrentPageAction, diff --git a/libs/reviews/state/src/effects/product-page-reviews.effects.ts b/libs/reviews/state/src/effects/product-page-reviews.effects.ts index 3079c00edd..38991d335a 100644 --- a/libs/reviews/state/src/effects/product-page-reviews.effects.ts +++ b/libs/reviews/state/src/effects/product-page-reviews.effects.ts @@ -19,10 +19,7 @@ import { import { DaffError } from '@daffodil/core'; import { ErrorTransformer } from '@daffodil/core/state'; -import { - DaffProductReview, - DAFF_REVIEWS_ERROR_MATCHER, -} from '@daffodil/reviews'; +import { DaffProductReview } from '@daffodil/reviews'; import { DaffReviewsDriver, DaffProductReviewsServiceInterface, @@ -34,6 +31,7 @@ import { DaffReviewsProductListFailure, DaffReviewsProductListSuccess, } from '../actions/product-reviews.actions'; +import { DAFF_REVIEWS_ERROR_MATCHER } from '../injection-tokens/public_api'; /** * Effects for handling product actions and for triggering corresponding service requests. diff --git a/libs/reviews/src/injection-tokens/error-matcher.token.ts b/libs/reviews/state/src/injection-tokens/error-matcher.token.ts similarity index 100% rename from libs/reviews/src/injection-tokens/error-matcher.token.ts rename to libs/reviews/state/src/injection-tokens/error-matcher.token.ts diff --git a/libs/reviews/src/injection-tokens/public_api.ts b/libs/reviews/state/src/injection-tokens/public_api.ts similarity index 100% rename from libs/reviews/src/injection-tokens/public_api.ts rename to libs/reviews/state/src/injection-tokens/public_api.ts diff --git a/libs/reviews/state/src/public_api.ts b/libs/reviews/state/src/public_api.ts index a3cbd7cee3..c1dfacb77b 100644 --- a/libs/reviews/state/src/public_api.ts +++ b/libs/reviews/state/src/public_api.ts @@ -2,5 +2,6 @@ export * from './actions/public_api'; export * from './facades/public_api'; export * from './reducers/public_api'; export * from './selectors/public_api'; +export * from './injection-tokens/public_api'; export { DaffReviewsStateModule } from './state.module';