diff --git a/apps/design-land/src/app/list/list.component.html b/apps/design-land/src/app/list/list.component.html index 0f3d4dcb64..e3779fafe7 100644 --- a/apps/design-land/src/app/list/list.component.html +++ b/apps/design-land/src/app/list/list.component.html @@ -16,11 +16,3 @@

Multi-line List

List with Icons

To add an icon to a list item, use the daffPrefix or daffSuffix attributes for the appropriate placements.

- -

Deprecation Notice

-

The mode property will be deprecated in v1.0.0.

- diff --git a/libs/design/list/README.md b/libs/design/list/README.md index fcba2dcd62..0bbf468b6d 100644 --- a/libs/design/list/README.md +++ b/libs/design/list/README.md @@ -20,10 +20,3 @@ For lists that have multiple lines per item, wrap each line appropriately with a To add an icon to a list item, use the `daffPrefix` or `daffSuffix` attributes for the appropriate placements. - -## Deprecation Notice -The `mode` property will be deprecated in v1.0.0. - -- `mode="navigation"` is replaced with ``. -- `mode="link"` is replaced with ``. -- `mode="multiline"` is completely deprecated. Multi-line lists will be a natural result of adding multiple lines to a ``. \ No newline at end of file diff --git a/libs/design/list/src/list-subheader/list-subheader.directive.spec.ts b/libs/design/list/src/list-subheader/list-subheader.directive.spec.ts deleted file mode 100644 index 555a05119d..0000000000 --- a/libs/design/list/src/list-subheader/list-subheader.directive.spec.ts +++ /dev/null @@ -1,54 +0,0 @@ -import { - Component, - DebugElement, -} from '@angular/core'; -import { - waitForAsync, - ComponentFixture, - TestBed, -} from '@angular/core/testing'; -import { By } from '@angular/platform-browser'; - -import { DaffListSubheaderDirective } from './list-subheader.directive'; - -@Component({ - template: ` -
Lorem Ipsum
- `, -}) -class WrapperComponent {} - -describe('@daffodil/design/list | DaffListSubheaderDirective', () => { - let wrapper: WrapperComponent; - let de: DebugElement; - let fixture: ComponentFixture; - - beforeEach(waitForAsync(() => { - TestBed.configureTestingModule({ - declarations: [ - DaffListSubheaderDirective, - WrapperComponent, - ], - }) - .compileComponents(); - })); - - beforeEach(() => { - fixture = TestBed.createComponent(WrapperComponent); - de = fixture.debugElement.query(By.css('[daffListSubheader]')); - wrapper = de.componentInstance; - fixture.detectChanges(); - }); - - it('should create', () => { - expect(wrapper).toBeTruthy(); - }); - - describe('[daffListSubheader]', () => { - it('should add a class of "daff-list__subheader" to the host element', () => { - expect(de.classes).toEqual(jasmine.objectContaining({ - 'daff-list__subheader': true, - })); - }); - }); -}); diff --git a/libs/design/list/src/list-subheader/list-subheader.directive.ts b/libs/design/list/src/list-subheader/list-subheader.directive.ts deleted file mode 100644 index c6d7ba12b4..0000000000 --- a/libs/design/list/src/list-subheader/list-subheader.directive.ts +++ /dev/null @@ -1,18 +0,0 @@ -import { - Directive, - HostBinding, -} from '@angular/core'; - -/** - * @deprecated - */ -@Directive({ - selector: '[daffListSubheader]', -}) -export class DaffListSubheaderDirective { - - /** - * @docs-private - */ - @HostBinding('class.daff-list__subheader') class = true; -} diff --git a/libs/design/list/src/list-theme.scss b/libs/design/list/src/list-theme.scss index 0ab6abef26..ff7a7dae93 100644 --- a/libs/design/list/src/list-theme.scss +++ b/libs/design/list/src/list-theme.scss @@ -19,40 +19,6 @@ } } } - - // link and navigation deprecated in v1.0.0 - &--link, - &--navigation { - a { - &:hover { - color: theming.daff-color($neutral, 80); - } - } - } - - // deprecated in v1.0.0 - &--navigation { - .daff-list-item { - &:hover { - background-color: theming.daff-illuminate($base, $neutral, 1); - } - } - } - - // deprecated in v1.0.0 - &--multi-line { - .daff-list-item { - &__content { - *:nth-child(1) { /* stylelint-disable-line scss/selector-nest-combinators */ - color: $base-contrast; - } - - *:nth-child(n + 2) { /* stylelint-disable-line scss/selector-nest-combinators */ - color: theming.daff-illuminate($base-contrast, $neutral, 3); - } - } - } - } } .daff-nav-list { diff --git a/libs/design/list/src/list.module.ts b/libs/design/list/src/list.module.ts index 83a6082211..3165d97905 100644 --- a/libs/design/list/src/list.module.ts +++ b/libs/design/list/src/list.module.ts @@ -5,7 +5,6 @@ import { DaffPrefixSuffixModule } from '@daffodil/design'; import { DaffListComponent } from './list/list.component'; import { DaffListItemComponent } from './list-item/list-item.component'; -import { DaffListSubheaderDirective } from './list-subheader/list-subheader.directive'; @NgModule({ imports: [ @@ -14,12 +13,10 @@ import { DaffListSubheaderDirective } from './list-subheader/list-subheader.dire ], declarations: [ DaffListComponent, - DaffListSubheaderDirective, DaffListItemComponent, ], exports: [ DaffListComponent, - DaffListSubheaderDirective, DaffListItemComponent, DaffPrefixSuffixModule, ], diff --git a/libs/design/list/src/list/list.component.scss b/libs/design/list/src/list/list.component.scss index 6fe3aeb45a..0add569d15 100644 --- a/libs/design/list/src/list/list.component.scss +++ b/libs/design/list/src/list/list.component.scss @@ -43,52 +43,6 @@ .daff-list { @include daff-list(); - - // .daff-list__subheader deprecated in v1.0.0 - &__subheader { - @include t.embolden; - @include t.uppercase; - font-size: 1rem; - padding: 0 0 25px; - } - - // link and navigation deprecated in v1.0.0 - &--link, - &--navigation { - a { - text-decoration: none; - } - } - - // deprecated in v1.0.0 - &--multi-line { - .daff-list-item { - padding: 15px 0; - - &:first-of-type { - padding: 0 0 15px; - } - - &:last-of-type { - padding: 15px 0 0; - } - - &__content { - *:nth-child(1) { /* stylelint-disable-line scss/selector-nest-combinators */ - @include t.embolden; - font-size: 1rem; - line-height: 1.5rem; - margin: 0 0 10px; - padding: 0; - } - - *:nth-child(n + 2) { /* stylelint-disable-line scss/selector-nest-combinators */ - margin: 0; - padding: 0; - } - } - } - } } .daff-nav-list { diff --git a/libs/design/list/src/list/list.component.spec.ts b/libs/design/list/src/list/list.component.spec.ts index 47536eb187..b195048df8 100644 --- a/libs/design/list/src/list/list.component.spec.ts +++ b/libs/design/list/src/list/list.component.spec.ts @@ -9,10 +9,7 @@ import { } from '@angular/core/testing'; import { By } from '@angular/platform-browser'; -import { - DaffListComponent, - DaffListMode, -} from './list.component'; +import { DaffListComponent } from './list.component'; @Component({ template: ` @@ -20,9 +17,7 @@ import { `, }) -class WrapperComponent { - mode: DaffListMode; -} +class WrapperComponent {} describe('@daffodil/design/list | DaffListComponent', () => { let wrapper: WrapperComponent; @@ -78,35 +73,4 @@ describe('@daffodil/design/list | DaffListComponent', () => { expect(navList.role).toBe('navigation'); }); }); - - describe('setting the mode', () => { - it('should not set a default mode', () => { - expect(component.mode).toBeFalsy(); - expect(de.nativeElement.classList.contains('daff-list--multi-line')).toBeFalsy(); - }); - - describe('when mode="multi-line"', () => { - it('should add a class of "daff-list--multi-line" to the host element', () => { - wrapper.mode = 'multi-line'; - fixture.detectChanges(); - expect(de.nativeElement.classList.contains('daff-list--multi-line')).toBeTruthy(); - }); - }); - - describe('when mode="link"', () => { - it('should add a class of "daff-list--link" to the host element', () => { - wrapper.mode = 'link'; - fixture.detectChanges(); - expect(de.nativeElement.classList.contains('daff-list--link')).toBeTruthy(); - }); - }); - - describe('when mode="navigation"', () => { - it('should add a class of "daff-list--navigation" to the host element', () => { - wrapper.mode = 'navigation'; - fixture.detectChanges(); - expect(de.nativeElement.classList.contains('daff-list--navigation')).toBeTruthy(); - }); - }); - }); }); diff --git a/libs/design/list/src/list/list.component.ts b/libs/design/list/src/list/list.component.ts index 01c4b76847..a28cd0f5f6 100644 --- a/libs/design/list/src/list/list.component.ts +++ b/libs/design/list/src/list/list.component.ts @@ -2,7 +2,6 @@ import { Component, ViewEncapsulation, ChangeDetectionStrategy, - Input, HostBinding, ElementRef, Renderer2, @@ -10,17 +9,6 @@ import { import { daffArticleEncapsulatedMixin } from '@daffodil/design'; -/** - * @deprecated - * DaffListMode will be completely deprecated in v1.0.0 - * */ -export type DaffListMode = 'multi-line' | 'link' | 'navigation' | undefined; -export enum DaffListModeEnum { - Multiline = 'multi-line', - Link = 'link', - Navigation = 'navigation' -} - export type DaffListType = 'daff-list' | 'daff-nav-list'; enum DaffListTypeEnum { @@ -48,11 +36,6 @@ const _daffListBase = daffArticleEncapsulatedMixin((DaffListBase)); }) export class DaffListComponent extends _daffListBase { - /** - * @deprecated - * */ - @Input() mode: DaffListMode; - /** * @docs-private */ @@ -60,30 +43,6 @@ export class DaffListComponent extends _daffListBase { return this.listType === DaffListTypeEnum.Default; } - /** - * @docs-private - * @deprecated - * */ - @HostBinding('class.daff-list--multi-line') get multiline() { - return this.mode === DaffListModeEnum.Multiline; - } - - /** - * @docs-private - * @deprecated - * */ - @HostBinding('class.daff-list--link') get link() { - return this.mode === DaffListModeEnum.Link; - } - - /** - * @docs-private - * @deprecated - * */ - @HostBinding('class.daff-list--navigation') get navigation() { - return this.mode === DaffListModeEnum.Navigation; - } - /** * @docs-private */ diff --git a/libs/design/list/src/public_api.ts b/libs/design/list/src/public_api.ts index bcfe64713a..00758e9019 100644 --- a/libs/design/list/src/public_api.ts +++ b/libs/design/list/src/public_api.ts @@ -1,4 +1,3 @@ export { DaffListModule } from './list.module'; export * from './list/list.component'; -export * from './list-subheader/list-subheader.directive'; export * from './list-item/list-item.component';