From cd823ad7e8cd3174dc382dbaa45b759c2d8557df Mon Sep 17 00:00:00 2001
From: griest024 <griest024@gmail.com>
Date: Fri, 7 Jun 2024 17:24:02 -0400
Subject: [PATCH] feat(cart): set shipping method `id` in magento driver
 (#2839)

---
 .../transforms/outputs/cart-shipping-rate.service.spec.ts  | 7 +++++--
 .../src/transforms/outputs/cart-shipping-rate.service.ts   | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.spec.ts b/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.spec.ts
index 3f07151c94..6a15c0dad4 100644
--- a/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.spec.ts
+++ b/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.spec.ts
@@ -1,5 +1,7 @@
 import { TestBed } from '@angular/core/testing';
 
+import { DaffCartShippingRate } from '@daffodil/cart';
+import { MagentoCartShippingMethod } from '@daffodil/cart/driver/magento';
 import { MagentoCartShippingMethodFactory } from '@daffodil/cart/driver/magento/testing';
 
 import { DaffMagentoCartShippingRateTransformer } from './cart-shipping-rate.service';
@@ -9,7 +11,7 @@ describe('@daffodil/cart/driver/magento | Transformer | MagentoCartShippingRate'
 
   let magentoShippingMethodFactory: MagentoCartShippingMethodFactory;
 
-  let mockMagentoShippingMethod;
+  let mockMagentoShippingMethod: MagentoCartShippingMethod;
 
   beforeEach(() => {
     TestBed.configureTestingModule({
@@ -30,7 +32,7 @@ describe('@daffodil/cart/driver/magento | Transformer | MagentoCartShippingRate'
   });
 
   describe('transform | transforming a cart shipping rate', () => {
-    let transformedCartShippingRate;
+    let transformedCartShippingRate: DaffCartShippingRate;
     let carrier;
     let price;
 
@@ -47,6 +49,7 @@ describe('@daffodil/cart/driver/magento | Transformer | MagentoCartShippingRate'
     it('should return an object with the correct values', () => {
       expect(transformedCartShippingRate.carrier).toEqual(carrier);
       expect(transformedCartShippingRate.price).toEqual(price);
+      expect(transformedCartShippingRate.id).toEqual(mockMagentoShippingMethod.method_code);
     });
 
     describe('when the argument is null', () => {
diff --git a/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.ts b/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.ts
index d3e50a77cf..f19c1648d0 100644
--- a/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.ts
+++ b/libs/cart/driver/magento/src/transforms/outputs/cart-shipping-rate.service.ts
@@ -23,9 +23,9 @@ export class DaffMagentoCartShippingRateTransformer {
       price: shippingMethod.amount.value,
       method_code: shippingMethod.method_code,
       method_title: shippingMethod.method_title,
+      id: shippingMethod.method_code,
 
       // TODO: implement
-      id: null,
       method_description: null,
     } : null;
   }