Undo free header after send #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem cause lost custom header and cookie not set with the bug fix:
PsychicHttp/src/PsychicResponse.cpp
Line 133 in 62f4439
I have problem with the login base cookie and captivate portal not open in iPhone with the fix for memory in in PsychicResponse::sendHeaders(), delete code free header it working normal, So better we investigate further by undo it . I log the header when app running and see you are not using
PsychicHttp/src/PsychicCore.h
Line 70 in 62f4439
We can also persistent headers/cookies bu not using malloc, use native Arduino String or c++ std::string is other option.