You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@nox any thoughts? Looking at fn new(), all it does is transmute to the uninhabitable type. Perhaps the unsafety can be contained inside the constructor? Is there any time calling it would be wrong?
Per Rust API Guidelines, unsafe functions should be documented with invariants:
https://rust-lang.github.io/api-guidelines/documentation.html
During review of the source, it was pointed out there is no safety comment here that describes what invariants are upheld:
hyper/src/proto/h2/server.rs
Line 478 in 90eb95f
Also UpgradedSendStream::new does not state which invariants need to be upheld.
Would it be possible to add this?
The text was updated successfully, but these errors were encountered: