Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose grpc_health_v1 descriptor set in tonic-health for use with the reflection service #619

Closed
byblakeorriver opened this issue Apr 30, 2021 · 0 comments · Fixed by #620 or #737
Closed
Labels
A-health C-request Category: A feature request, i.e: not implemented / a PR.

Comments

@byblakeorriver
Copy link
Contributor

It would be nice to expose the grpc_health_v1 descriptor set in the tonic-health container so that it can be accessed for registering with the reflection service in tonic-reflection.

In order to use tools like grpcui and grpcurl the grpc server has to expose the reflection service. Thus, if I wanted to hit the health endpoints with those tools, I would have to register the descriptor set of the health service in the reflection service. Currently, I have to keep a copy of the health.proto file locally and build the descriptor set with prost. This could be alleviated by building and exposing the descriptor set in the tonic-health crate.

If this is something that would be acceptable, I could open a PR with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-health C-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
2 participants