Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tonic): derive Clone for RouterService #714

Merged
merged 1 commit into from
Jul 11, 2021
Merged

feat(tonic): derive Clone for RouterService #714

merged 1 commit into from
Jul 11, 2021

Conversation

cab
Copy link
Contributor

@cab cab commented Jul 11, 2021

Motivation

Implementing Clone for RouterService makes it easier to use with hyper::service::make_service_fn and tower::service_fn. (For example, when using the pattern in this example).

Solution

Derive Clone for RouterService.

@davidpdrsn davidpdrsn changed the title derive Clone for RouterService feat(tonic): derive Clone for RouterService Jul 11, 2021
davidpdrsn
davidpdrsn approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@davidpdrsn davidpdrsn merged commit 0a06603 into hyperium:master Jul 11, 2021
@davidpdrsn davidpdrsn mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cab @davidpdrsn