Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yes/no instead of true/false for boolean keys #48

Closed
alranel opened this issue Mar 18, 2019 · 1 comment
Closed

Use yes/no instead of true/false for boolean keys #48

alranel opened this issue Mar 18, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@alranel
Copy link
Member

alranel commented Mar 18, 2019

As discussed in https://github.com/italia/publiccode.yml/issues/8, we should use the literals yes and no values for boolean values instead of true and false, since they are supported by the YAML spec:

A Boolean represents a true/false value. Booleans are formatted as English words (“true”/“false”,
“yes”/“no” or “on”/“off”) for readability and may be abbreviated as a single character “y”/“n” or “Y”/“N”.

source: https://yaml.org/type/bool.html

We should probably check whether the YAML library we use for serialization supports this.

@alranel alranel added the enhancement New feature or request label Mar 18, 2019
@alranel alranel added this to the 1.1 milestone Mar 18, 2019
@alranel alranel changed the title Use yes/no instead of true/false for boolean key Use yes/no instead of true/false for boolean keys Mar 18, 2019
@sebbalex
Copy link
Member

YAML 1.2 has deprecated bool type y/n/yes/no/on/off. spec
Only true and false are valid bool type.
@alranel @libremente We should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants